From kde-bugs-dist  Sat Aug 30 16:19:00 2003
From: Sven Lueppken <sven () kde ! org>
Date: Sat, 30 Aug 2003 16:19:00 +0000
To: kde-bugs-dist
Subject: [Bug 63059] khtmlimagepart: no right mouse button or location menue
X-MARC-Message: https://marc.info/?l=kde-bugs-dist&m=106226145823910

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
     
http://bugs.kde.org/show_bug.cgi?id=63059     
sven@kde.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From sven@kde.org  2003-08-30 18:18 -------
Subject: kdelibs/khtml

CVS commit by lueppken: 

-Fixed (annoying :) bug #63059. When loading an image with khtmlimagepart the
popupmenu now appears again when right-clicking on the image.
-Removed the old connects and an old slot which isn't used anymore.

CCMAIL: 63059-done@bugs.kde.org


  M +3 -11     khtmlimage.cpp   1.32
  M +0 -1      khtmlimage.h   1.8


--- kdelibs/khtml/khtmlimage.cpp  #1.31:1.32
@@ -96,9 +96,7 @@ KHTMLImage::KHTMLImage( QWidget *parentW
     }
 
-    //connect( m_khtml->browserExtension(), SIGNAL( popupMenu( KXMLGUIClient *, const QPoint &, const KURL &, const QString &, mode_t ) ),
-    //         this, SLOT( slotPopupMenu( KXMLGUIClient *, const QPoint &, const KURL &, const QString &, mode_t ) ) );
-
-    connect( m_khtml->browserExtension(), SIGNAL( popupMenu( KXMLGUIClient *, const QPoint &, const KURL &, const QString &, mode_t ) ),
-             m_ext, SIGNAL( popupMenu( KXMLGUIClient *, const QPoint &, const KURL &, const QString &, mode_t ) ) );
+    connect( m_khtml->browserExtension(), SIGNAL( popupMenu( KXMLGUIClient *, const QPoint &, const KURL &,
+             const KParts::URLArgs &, mode_t) ), m_ext, SIGNAL( popupMenu( KXMLGUIClient *, const QPoint &, const KURL &,
+             const KParts::URLArgs &, mode_t) ) );
 
     connect( m_khtml->browserExtension(), SIGNAL( enableAction( const char *, bool ) ),
@@ -158,10 +156,4 @@ void KHTMLImage::guiActivateEvent( KPart
     if ( e->activated() )
         emit setWindowCaption( m_url.prettyURL() );
-}
-
-void KHTMLImage::slotPopupMenu( KXMLGUIClient *cl, const QPoint &pos, const KURL &u,
-                                const QString &, mode_t mode )
-{
-    emit m_ext->popupMenu( cl, pos, u, m_mimeType, mode );
 }
 

--- kdelibs/khtml/khtmlimage.h  #1.7:1.8
@@ -72,5 +72,4 @@ protected:
 
 private slots:
-    void slotPopupMenu( KXMLGUIClient *cl, const QPoint &pos, const KURL &u, const QString &mime, mode_t mode );
     void slotImageJobFinished( KIO::Job *job );