[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 54196] meta-info tooltip (mis)positioned with at least parts
From:       Laurence Anderson <l.d.anderson () warwick ! ac ! uk>
Date:       2003-05-25 20:10:45
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
     
http://bugs.kde.org/show_bug.cgi?id=54196     




------- Additional Comments From l.d.anderson@warwick.ac.uk  2003-05-25 22:10 -------
Subject: kdebase/libkonq

CVS commit by landers: 

If the metainfo tip is moved to fit on the screen, remove arrow pointing to file, as \
it may point to the wrong file if the tip has been shifted. Only happens on small \
screens as metainfo length is limited to 50.

CCMAIL:54196@bugs.kde.org


  M +8 -5      konq_iconviewwidget.cc   1.237


--- kdebase/libkonq/konq_iconviewwidget.cc  #1.236:1.237
@@ -116,5 +116,5 @@ private:
     bool       m_on;
     bool       m_preview;
-    QPixmap    m_corners[4];
+    QPixmap    m_corners[5];
     int        m_corner;
     bool       m_filter;
@@ -182,4 +182,5 @@ void KFileTip::reposition()
     // 2: lowerleft
     // 3: lowerright
+    // 4: none
     m_corner = 0;
     // should the tooltip be shown to the left or to the right of the ivi ?
@@ -188,10 +189,12 @@ void KFileTip::reposition()
     {
         // to the left
-        if (pos.x() - width() < 0)
+        if (pos.x() - width() < 0) {
             pos.setX(0);
-        else
+            m_corner = 4;
+        } else {
             pos.setX( pos.x() - width() );
         m_corner = 1;
     }
+    }
     // should the tooltip be shown above or below the ivi ?
     if (rect.bottom() + height() > desk.bottom())
@@ -229,5 +232,5 @@ void KFileTip::drawContents( QPainter *p
     };
 
-    if ( m_corners[m_corner].isNull() )
+    if ( m_corners[m_corner].isNull() && m_corner < 4 ) // 4 is empty, so don't draw \
                anything
         m_corners[m_corner].load( locate( "data", QString::fromLatin1( \
"konqueror/pics/%1.png" ).arg( names[m_corner] ) ) );


[prev in list] [next in list] [prev in thread] [next in thread]