[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 56053] When setting dark color scheme, disabled menu items are completely illegible
From:       Leif Huhn <leif () dkstat ! com>
Date:       2003-03-20 23:19:06
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
     
http://bugs.kde.org/show_bug.cgi?id=56053     




------- Additional Comments From leif@dkstat.com  2003-03-21 00:18 -------
The bug is in kdelibs/kdecore/kapplication.cpp, at around line 1718 
 
    QColorGroup disabledgrp(disfg, background, 
                            background.light(highlightVal), 
                            background.dark(lowlightVal), 
                            background.dark(120), 
                            background.dark(120), base); 
 
    QColorGroup colgrp(foreground, background, background.light(highlightVal), 
                       background.dark(lowlightVal), 
                       background.dark(120), 
                       baseText, base); 
 
baseText is the color of a normal menu entry.  It is stored in the QColorGroup colgrp.  
The analagous entry for disabledgrp is background.dark(120).  This just makes the 
color darker, without any regard to it being lighter.  It would be nice if this color entry 
was given the same treatement as the text color for buttons further down (~line 
1743): 
 
    QColor disbtntext = buttonText; 
    disbtntext.hsv( &h, &s, &v ); 
    if (v > 128) 
        // dark button, light buttonText - need a darker disabled buttonText 
        disbtntext = disbtntext.dark(lowlightVal); 
    else if (disbtntext != black) 
        // light buttonText, dark button - need a lighter disabled buttonText - but only if 
!black 
        disbtntext = disbtntext.light(highlightVal); 
    else 
        // black button - use darkgrey disabled buttonText 
        disbtntext = Qt::darkGray;
[prev in list] [next in list] [prev in thread] [next in thread]