[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    Bug#39662: noatun can't save/load utf8 playlist correctly
From:       Takumi ASAKI <asataku () osk3 ! 3web ! ne ! jp>
Date:       2002-03-23 1:51:22
[Download RAW message or body]

Neil Stevens wrote:

>Latin1 will lose information.  utf8 won't.  So it's better to be safe and
>set utf8.

Thank you for advice.
OK. I remake patch.
In original souce, QString val has UTF8-codec string(not Unicode-raw).
So if saver use UnicodeUTF8 encoding, file is broken.
New patch QString val has Unicode-raw string.
and use UnicodeUTF8 encoding to save.

How about it?

-- 
  Che Che - Bye Bye
        From: Takumi ASAKI <asataku@osk3.3web.ne.jp>
	URL: http://www3.osk.3web.ne.jp/~asataku/

["kdemultimedia-3.0-cvs-noatun-playlist-i18n-20020323.diff" (text/x-diff)]

diff -ur kdemultimedia.orig/noatun/library/playlistsaver.cpp \
                kdemultimedia/noatun/library/playlistsaver.cpp
--- kdemultimedia.orig/noatun/library/playlistsaver.cpp	Tue Mar 19 01:05:43 2002
+++ kdemultimedia/noatun/library/playlistsaver.cpp	Sat Mar 23 10:44:33 2002
@@ -111,7 +111,8 @@
 		QDomElement elem=doc.createElement("item");
 		for (QStringList::Iterator pi(props.begin()); pi!=props.end(); ++pi)
 		{
-			QString val=QString::fromLatin1(i.property(*pi).utf8());
+			// QString val=QString::fromLatin1(i.property(*pi).utf8());
+			QString val=i.property(*pi);
 			elem.setAttribute(*pi, val);
 			
 			if ((*pi)=="url")
@@ -130,6 +131,7 @@
 	Noatun::KSaver saver(local);
 	if (!saver.open())
 		return false;
+	saver.textStream().setEncoding(QTextStream::UnicodeUTF8);
 	saver.textStream() << doc.toString();
 	saver.close();
 



[prev in list] [next in list] [prev in thread] [next in thread]