[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-bindings
Subject: Re: PyKF5 bindings generator improvements out for review.
From: Shaheed Haque <srhaque () theiet ! org>
Date: 2017-02-08 18:53:06
Message-ID: CAHAc2jcNjMkoxQqwHFwn9kzaYA37pn6hgMN6H26YQgKe6GM8yQ () mail ! gmail ! com
[Download RAW message or body]
I've posted the first 3 reviews in Phabricator, not least to make sure I
have understood the process. Feedback welcome on:
https://phabricator.kde.org/D4509
https://phabricator.kde.org/D4510
https://phabricator.kde.org/D4511
Thanks, Shaheed
On 6 February 2017 at 18:45, Shaheed Haque <srhaque@theiet.org> wrote:
> Luca, Luigi, all,
>
> I take responsibility for not being aware of the expectations here (it
> seems I have been away from KDE for too long!), so apologies for that. I've
> had a quick look into Phabricator and will look to post the reviews there.
> Steve, I take it you will be OK with that, so I'll close the PRs.
>
> Thanks, Shaheed
>
>
> On 5 February 2017 at 21:25, Luca Beltrame <lbeltrame@kde.org> wrote:
>
>> Il giorno Sun, 5 Feb 2017 14:36:26 +0000
>> Shaheed Haque <srhaque@theiet.org> ha scritto:
>>
>> Hello Shaheed and Steve,
>>
>> > I've reviewed what got merged from PR2 and PR3, and reworked PR4 into
>> > what I hope is a much more manageable form. The results are in PR9:
>> >
>> > https://github.com/ShaheedHaque/extra-cmake-modules/pull/9
>>
>> I hate to be "that guy", but I have to tell you that doing GH pull
>> requests is not the way to go for a number of reasons:
>>
>> - Even if not many touch ECM, it means the few that aren't on GH won't
>> review your code;
>> - The ongoing review, for the same reason, is in a place inaccessible
>> to most people with a KDE contributor account;
>> - The KDE Manifesto mandates the use of KDE infrastructure for KDE
>> projects: this means either Reviewboard (going to get retired) or
>> Phabricator.
>>
>> Please don't lock out the larger KDE community just for your own
>> convenience.
>>
>> --
>> Luca Beltrame - KDE Forums team
>> GPG key ID: A29D259B
>>
>
>
[Attachment #3 (text/html)]
<div dir="ltr"><div>I've posted the first 3 reviews in Phabricator, not least to \
make sure I have understood the process. Feedback welcome on:<br><br><a \
href="https://phabricator.kde.org/D4509">https://phabricator.kde.org/D4509</a><br><a \
href="https://phabricator.kde.org/D4510">https://phabricator.kde.org/D4510</a><br><a \
href="https://phabricator.kde.org/D4511">https://phabricator.kde.org/D4511</a><br><br></div>Thanks, \
Shaheed<br></div><div class="gmail_extra"><br><div class="gmail_quote">On 6 February \
2017 at 18:45, Shaheed Haque <span dir="ltr"><<a href="mailto:srhaque@theiet.org" \
target="_blank">srhaque@theiet.org</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div><div>Luca, Luigi, all,<br><br></div>I \
take responsibility for not being aware of the expectations here (it seems I have \
been away from KDE for too long!), so apologies for that. I've had a quick look \
into Phabricator and will look to post the reviews there. Steve, I take it you will \
be OK with that, so I'll close the PRs.<br><br></div>Thanks, \
Shaheed<br><div><br></div></div><div class="HOEnZb"><div class="h5"><div \
class="gmail_extra"><br><div class="gmail_quote">On 5 February 2017 at 21:25, Luca \
Beltrame <span dir="ltr"><<a href="mailto:lbeltrame@kde.org" \
target="_blank">lbeltrame@kde.org</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Il giorno Sun, 5 Feb 2017 14:36:26 +0000<br> Shaheed Haque \
<<a href="mailto:srhaque@theiet.org" target="_blank">srhaque@theiet.org</a>> ha \
scritto:<br> <br>
Hello Shaheed and Steve,<br>
<span><br>
> I've reviewed what got merged from PR2 and PR3, and reworked PR4 into<br>
> what I hope is a much more manageable form. The results are in PR9:<br>
><br>
> <a href="https://github.com/ShaheedHaque/extra-cmake-modules/pull/9" \
rel="noreferrer" target="_blank">https://github.com/ShaheedHaqu<wbr>e/extra-cmake-modules/pull/9</a><br>
<br>
</span>I hate to be "that guy", but I have to tell you that doing GH \
pull<br> requests is not the way to go for a number of reasons:<br>
<br>
- Even if not many touch ECM, it means the few that aren't on GH won't<br>
review your code;<br>
- The ongoing review, for the same reason, is in a place inaccessible<br>
to most people with a KDE contributor account;<br>
- The KDE Manifesto mandates the use of KDE infrastructure for KDE<br>
projects: this means either Reviewboard (going to get retired) or<br>
Phabricator.<br>
<br>
Please don't lock out the larger KDE community just for your own<br>
convenience.<br>
<span class="m_6234049993401294545HOEnZb"><font color="#888888"><br>
--<br>
Luca Beltrame - KDE Forums team<br>
GPG key ID: A29D259B<br>
</font></span></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic