[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-bindings
Subject: Re: PyKF5 bindings generator improvements out for review.
From: Shaheed Haque <srhaque () theiet ! org>
Date: 2017-02-03 21:53:55
Message-ID: CAHAc2jcAyTUDX8ZiaYLxiJiM+X2Dp-O1ty0MUJwfsN-CySMJOA () mail ! gmail ! com
[Download RAW message or body]
Steve,
PRs 2 through 7, at
https://github.com/ShaheedHaque/extra-cmake-modules/pulls are now the
complete set of the changes required to bring the mainstream'd fork up to
par with mine.
I'll be continuing the bringup of the automatic QMap/QList/etc and array
stuff; hopefully you'll have a chance to review the above.
Thanks, Shaheed
On 31 January 2017 at 22:26, Shaheed Haque <srhaque@theiet.org> wrote:
> And now https://github.com/ShaheedHaque/extra-cmake-modules/pull/4...
>
>
> On 30 January 2017 at 22:17, Shaheed Haque <srhaque@theiet.org> wrote:
>
>> I also put out https://github.com/ShaheedHaque/extra-cmake-modules/pull/3
>> .
>>
>>
>> On 29 January 2017 at 21:09, Shaheed Haque <srhaque@theiet.org> wrote:
>>
>>> OK, let's start small: https://github.com/ShaheedHaqu
>>> e/extra-cmake-modules/pull/2.
>>>
>>> Please review...
>>>
>>> On 29 January 2017 at 17:12, Stephen Kelly <steveire@gmail.com> wrote:
>>>
>>>> Shaheed Haque wrote:
>>>>
>>>> > Rewrite? It think its more a case of forking making things diverge
>>>> (if you
>>>> > look, a lot of the changes are formatting, name changes and comments,
>>>> > though I accept that does make for a lot of noise). I have tried VERY
>>>> hard
>>>> > to keep the good changes form both sides...and yes, there ARE a
>>>> reasonable
>>>> > number of actual changes too.
>>>> >
>>>> > Anyway, I was under the impression a squashed single commit was
>>>> preferred,
>>>> > but I can look to pull things out again. I would prefer to work the
>>>> > reviews via github's Pull Requests, is that still OK?
>>>>
>>>> Yep, sounds good to me!
>>>>
>>>> Thanks,
>>>>
>>>> Steve.
>>>>
>>>>
>>>
>>
>
[Attachment #3 (text/html)]
<div dir="ltr"><div><div><div>Steve,<br><br></div>PRs 2 through 7, at <a \
href="https://github.com/ShaheedHaque/extra-cmake-modules/pulls">https://github.com/ShaheedHaque/extra-cmake-modules/pulls</a> \
are now the complete set of the changes required to bring the mainstream'd fork \
up to par with mine.<br><br></div>I'll be continuing the bringup of the automatic \
QMap/QList/etc and array stuff; hopefully you'll have a chance to review the \
above.<br><br></div>Thanks, Shaheed<br><div><div><div><br><div \
class="gmail_extra"><br><div class="gmail_quote">On 31 January 2017 at 22:26, Shaheed \
Haque <span dir="ltr"><<a href="mailto:srhaque@theiet.org" \
target="_blank">srhaque@theiet.org</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr">And now <a \
href="https://github.com/ShaheedHaque/extra-cmake-modules/pull/4." \
target="_blank">https://github.com/<wbr>ShaheedHaque/extra-cmake-<wbr>modules/pull/4.</a>..<div><div \
class="gmail-h5"><br><div class="gmail_extra"><br><div class="gmail_quote">On 30 \
January 2017 at 22:17, Shaheed Haque <span dir="ltr"><<a \
href="mailto:srhaque@theiet.org" target="_blank">srhaque@theiet.org</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I also \
put out <a href="https://github.com/ShaheedHaque/extra-cmake-modules/pull/3" \
target="_blank">https://github.com/ShaheedHaqu<wbr>e/extra-cmake-modules/pull/3</a>.<br><br></div><div \
class="gmail-m_5985240500455448504HOEnZb"><div \
class="gmail-m_5985240500455448504h5"><div class="gmail_extra"><br><div \
class="gmail_quote">On 29 January 2017 at 21:09, Shaheed Haque <span dir="ltr"><<a \
href="mailto:srhaque@theiet.org" target="_blank">srhaque@theiet.org</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div \
dir="ltr"><div>OK, let's start small: <a \
href="https://github.com/ShaheedHaque/extra-cmake-modules/pull/2" \
target="_blank">https://github.com/ShaheedHaqu<wbr>e/extra-cmake-modules/pull/2</a>.<br><br></div>Please \
review...<br></div><div \
class="gmail-m_5985240500455448504m_2249465440063826934HOEnZb"><div \
class="gmail-m_5985240500455448504m_2249465440063826934h5"><div \
class="gmail_extra"><br><div class="gmail_quote">On 29 January 2017 at 17:12, Stephen \
Kelly <span dir="ltr"><<a href="mailto:steveire@gmail.com" \
target="_blank">steveire@gmail.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><span>Shaheed Haque wrote:<br> <br>
> Rewrite? It think its more a case of forking making things diverge (if you<br>
> look, a lot of the changes are formatting, name changes and comments,<br>
> though I accept that does make for a lot of noise). I have tried VERY hard<br>
> to keep the good changes form both sides...and yes, there ARE a reasonable<br>
> number of actual changes too.<br>
><br>
> Anyway, I was under the impression a squashed single commit was preferred,<br>
> but I can look to pull things out again. I would prefer to work the<br>
> reviews via github's Pull Requests, is that still OK?<br>
<br>
</span>Yep, sounds good to me!<br>
<br>
Thanks,<br>
<br>
Steve.<br>
<br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div></div></div></div>
</blockquote></div><br></div></div></div></div></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic