'Re: [Kde-bindings] Progress report on Py*5 binding generation'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bindings
Subject:    Re: [Kde-bindings] Progress report on Py*5 binding generation
From:       Shaheed Haque <srhaque () theiet ! org>
Date:       2016-05-02 12:40:30
Message-ID: CAHAc2jeJieLQzi4Y2REcBXgvptM8YRqMKWhRk1WdoWnb9U_iXQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

Hi Steve,

On 1 May 2016 at 20:25, Stephen Kelly <steveire@gmail.com> wrote:

> Stephen Kelly wrote:
>
> > Shaheed Haque wrote:
> >
> >> Steve, do you know what point in the upstream code you forked? Knowing
> >> that would help me work out what you did/need (I might have committed
> the
> >> original code before the forked copies, but c'est la vie).
> >
> > To see the differences make sure your 'git status' on the pykde5 repo is
> > clean, clone the extra-cmake-modules repo (I have pushed to the master
> > branch on my clone now), and copy the files from there to the pykde5
> repo.
> >
> > Then run 'git diff'.
> >
> > Does that answer your question about what has changed? The above steps
> > should be very obvious, so I might have just misunderstood the question.
>
> I have integrated the current state of those files in your branch in the
> extra-cmake-modules repo. The first commit (with your authorship) is
> pristine to make the following changes more visible.
>

OK, that pristine state was the bit I was missing: from looking at github's
history, it was not clear to me what the basis of the diff needed to be.

> Some of my changes are exploratory (eg regarding namespacing of enums
> properly for sip and trying to find the initializer for parameters), but
> really it can't be done better until we are collaborating in one place
> instead of two.
>

I see a variety of changes, and the enhancements in sip_generator.py look
immediately useful. I need to find time to study/incorporate those and also
take a more detailed look at rules_engine.py to see how best to converge.

Till we get to that point, perhaps it would at least help if we worked in
the same repo, so we could more easily cherry pick and/or merge. I'd be
happy to work in a fork of your ECM on github if you agree that will help
us?

Thanks, Shaheed

Thanks,
>
> Steve.
> _______________________________________________
> Kde-bindings mailing list
> Kde-bindings@kde.org
> https://mail.kde.org/mailman/listinfo/kde-bindings
>

[Attachment #5 (text/html)]

<div dir="ltr">Hi Steve,<br><div class="gmail_extra"><br><div class="gmail_quote">On \
1 May 2016 at 20:25, Stephen Kelly <span dir="ltr">&lt;<a \
href="mailto:steveire@gmail.com" target="_blank">steveire@gmail.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"><span class="">Stephen Kelly wrote:<br> <br>
&gt; Shaheed Haque wrote:<br>
&gt;<br>
&gt;&gt; Steve, do you know what point in the upstream code you forked? Knowing<br>
&gt;&gt; that would help me work out what you did/need (I might have committed \
the<br> &gt;&gt; original code before the forked copies, but c&#39;est la vie).<br>
&gt;<br>
&gt; To see the differences make sure your &#39;git status&#39; on the pykde5 repo \
is<br> &gt; clean, clone the extra-cmake-modules repo (I have pushed to the \
master<br> &gt; branch on my clone now), and copy the files from there to the pykde5 \
repo.<br> &gt;<br>
&gt; Then run &#39;git diff&#39;.<br>
&gt;<br>
&gt; Does that answer your question about what has changed? The above steps<br>
&gt; should be very obvious, so I might have just misunderstood the question.<br>
<br>
</span>I have integrated the current state of those files in your branch in the<br>
extra-cmake-modules repo. The first commit (with your authorship) is<br>
pristine to make the following changes more \
visible.<br></blockquote><div><br></div><div>OK, that pristine state was the bit I \
was missing: from looking at github&#39;s history, it was not clear to me what the \
basis of the diff needed to be.<br>  </div><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Some of my \
changes are exploratory (eg regarding namespacing of enums<br> properly for sip and \
trying to find the initializer for parameters), but<br> really it can&#39;t be done \
better until we are collaborating in one place<br> instead of \
two.<br></blockquote><div><br></div><div>I see a variety of changes, and the \
enhancements in sip_generator.py look immediately useful. I need to find time to \
study/incorporate those and also take a more detailed look at rules_engine.py to see \
how best to converge.<br></div><div><br></div><div>Till we get to that point, perhaps \
it would at least help if we worked in the same repo, so we could more easily cherry \
pick and/or merge. I&#39;d be happy to work in a fork of your ECM on github if you \
agree that will help us?<br><br></div><div>Thanks, \
Shaheed<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"> <div class="HOEnZb"><div \
class="h5">Thanks,<br> <br>
Steve.<br>
_______________________________________________<br>
Kde-bindings mailing list<br>
<a href="mailto:Kde-bindings@kde.org">Kde-bindings@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-bindings" rel="noreferrer" \
target="_blank">https://mail.kde.org/mailman/listinfo/kde-bindings</a><br> \
</div></div></blockquote></div><br><br></div></div>

[Attachment #6 (text/plain)]

_______________________________________________
Kde-bindings mailing list
Kde-bindings@kde.org
https://mail.kde.org/mailman/listinfo/kde-bindings

[prev in list] [next in list] [prev in thread] [next in thread] 