'Re: [Kde-bindings] Review Request 101903: Make SIP files install dir relative to CMAKE_INSTALL_PREFI'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bindings
Subject:    Re: [Kde-bindings] Review Request 101903: Make SIP files install dir relative to CMAKE_INSTALL_PREFI
From:       "Luca Beltrame" <lbeltrame () kde ! org>
Date:       2013-03-02 14:44:21
Message-ID: 20130302144421.27137.72799 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101903/#review28381
-----------------------------------------------------------

Ship it!

Ship It!

- Luca Beltrame

On July 9, 2011, 6:07 p.m., Artem Serebriyskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101903/
> -----------------------------------------------------------
> 
> (Updated July 9, 2011, 6:07 p.m.)
> 
> 
> Review request for KDE Bindings.
> 
> 
> Description
> -------
> 
> Replace SIP_DEFAULT_SIP_DIR with ${CMAKE_INSTALL_PREFIX}/share/sip. Otherwise \
> installing pykde localy with system-wide SIP was impossible 
> 
> Diffs
> -----
> 
> CMakeLists.txt c853e38 
> 
> Diff: http://git.reviewboard.kde.org/r/101903/diff/
> 
> 
> Testing
> -------
> 
> python importTest run successfully.
> 
> 
> Thanks,
> 
> Artem Serebriyskiy
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101903/">http://git.reviewboard.kde.org/r/101903/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Luca</p>

<br />
<p>On July 9th, 2011, 6:07 p.m. UTC, Artem Serebriyskiy wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Bindings.</div>
<div>By Artem Serebriyskiy.</div>

<p style="color: grey;"><i>Updated July 9, 2011, 6:07 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Replace SIP_DEFAULT_SIP_DIR with ${CMAKE_INSTALL_PREFIX}/share/sip. \
Otherwise installing pykde localy with system-wide SIP was impossible</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">python importTest run successfully.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(c853e38)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101903/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-bindings mailing list
Kde-bindings@kde.org
https://mail.kde.org/mailman/listinfo/kde-bindings

[prev in list] [next in list] [prev in thread] [next in thread] 