[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bindings
Subject:    [Kde-bindings] KDE/kdebindings/smoke/qt
From:       Kevin Kofler <kevin.kofler () chello ! at>
Date:       2008-05-27 21:38:18
Message-ID: 1211924298.834435.22332.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 813504 by kkofler:

Fix this thing for lib64 AGAIN (see also \
http://websvn.kde.org/?view=rev&revision=774199 ). 

Hardcoding ${CMAKE_INSTALL_PREFIX}/lib for the libdir breaks all multilib platforms \
(e.g. the 64-bit versions of all distributions which support multilib, e.g. Fedora). \
The correct libdir on 64-bit multilib platforms is ${CMAKE_INSTALL_PREFIX}/lib64. \
This regression was introduced by: http://websvn.kde.org/?view=rev&revision=804510

I'm using ${CMAKE_INSTALL_PREFIX}/lib${LIB_SUFFIX} instead of just \
${CMAKE_INSTALL_PREFIX}/lib now. I'm not convinced hardcoding the libdir like this \
instead of using ${LIB_INSTALL_DIR} which is user-settable is the right solution in \
the first place though. Maybe you should set ${LIB_INSTALL_DIR} to the hardcoded \
value if (and only if) not set yet, then use it?

CCMAIL: kde-bindings@kde.org

 M  +1 -1      CMakeLists.txt  


--- trunk/KDE/kdebindings/smoke/qt/CMakeLists.txt #813503:813504
@@ -144,7 +144,7 @@
 
 # Don't use the KDE ${LIB_INSTALL_DIR} macro here as this file is
 # for Qt only installs
-install(TARGETS smokeqt DESTINATION ${CMAKE_INSTALL_PREFIX}/lib )
+install(TARGETS smokeqt DESTINATION ${CMAKE_INSTALL_PREFIX}/lib${LIB_SUFFIX} )
 install(FILES qt_smoke.h DESTINATION include/smoke/qt)
 
 configure_file(qtguess.pl.cmake ${CMAKE_CURRENT_BINARY_DIR}/qtguess.pl @ONLY)
_______________________________________________
Kde-bindings mailing list
Kde-bindings@kde.org
https://mail.kde.org/mailman/listinfo/kde-bindings


[prev in list] [next in list] [prev in thread] [next in thread]