[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bindings
Subject:    Re: [Kde-bindings] branches/KDE/3.5/kdebindings/korundum
From:       Han Holl <han.holl () pobox ! com>
Date:       2007-07-06 20:31:43
Message-ID: 200707062231.43806.han.holl () pobox ! com
[Download RAW message or body]

On Friday 06 July 2007, Richard Dale wrote:
> SVN commit 684234 by rdale:
>
> * Fixed bug in DCOPRef's reported by Han Holl, but how has it ever worked?
>
> CCMAIL: kde-bindings@kde.org
>
>
>
>  M  +4 -0      ChangeLog
>  M  +1 -1      rubylib/korundum/lib/KDE/korundum.rb
>
>
> --- branches/KDE/3.5/kdebindings/korundum/ChangeLog #684233:684234
> @@ -1,3 +1,7 @@
> +2007-07-06  Richard Dale  <rdale@foton.es>
> +
> +	* Fixed bug in DCOPRef's reported by Han Holl, but how has it ever
> worked? +
>  2007-02-19  Richard Dale  <rdale@foton.es>
>
>  	* Fixed a bug where the sort method of KDE::ListView and
> KDE::ListViewItem ---
> branches/KDE/3.5/kdebindings/korundum/rubylib/korundum/lib/KDE/korundum.rb
> #684233:684234 @@ -211,7 +211,7 @@
>
>  				# Get the functions() for this dcop ref and
>  				# cache method_name => full_type_signature in a hash
> -				if !defined(@functions) || @functions.nil?
> +				if @functions.nil?
>  					@functions = {}
>  					funcs = call("functions()")
>  					if funcs.nil?
> _______________________________________________
> Kde-bindings mailing list
> Kde-bindings@kde.org
> https://mail.kde.org/mailman/listinfo/kde-bindings

I don't think this fix is complete: you will get lots of warnings about 
undefined @functions variable.
Correct is:
Either:
				if !defined?(@functions) || @functions.nil?
(with question mark), or the above with the addition of a constructor like:
  def initialize(*args)
      super
      @functions = nil
   end

Cheers

Han Holl


_______________________________________________
Kde-bindings mailing list
Kde-bindings@kde.org
https://mail.kde.org/mailman/listinfo/kde-bindings
[prev in list] [next in list] [prev in thread] [next in thread]