[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bindings
Subject:    [Kde-bindings] branches/KDE/3.5/kdebindings/qtruby
From:       Richard Dale <Richard_Dale () tipitina ! demon ! co ! uk>
Date:       2005-12-06 14:02:22
Message-ID: 1133877742.474237.14509.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 486009 by rdale:

2005-12-06  Richard Dale  <Richard_Dale@tipitina.demon.co.uk>

* QtRuby didn't work with versions of ruby > 1.8.3, as it didn't call
  initialize methods correctly. It used the rb_respond_to() method
  to check it a newly created qt instance responded to :initialize.
  However, in newer versions of ruby rb_responds_to() ignores
  private methods such as initialize(). The solution was to just remove
  the test, as it was redundant anyway.
* Fixes problem reported by Hans Fugel and Caleb Tennis.

CCMAIL: kde-bindings@kde.org



 M  +10 -0     ChangeLog  
 M  +0 -3      rubylib/qtruby/Qt.cpp  


--- branches/KDE/3.5/kdebindings/qtruby/ChangeLog #486008:486009
@@ -1,3 +1,13 @@
+2005-12-06  Richard Dale  <Richard_Dale@tipitina.demon.co.uk>
+
+	* QtRuby didn't work with versions of ruby > 1.8.3, as it didn't call
+	  initialize methods correctly. It used the rb_respond_to() method
+	  to check it a newly created qt instance responded to :initialize.
+	  However, in newer versions of ruby rb_responds_to() ignores
+	  private methods such as initialize(). The solution was to just remove
+	  the test, as it was redundant anyway.
+	* Fixes problem reported by Hans Fugel and Caleb Tennis.
+
 2005-11-21  Richard Dale  <Richard_Dale@tipitina.demon.co.uk>
 
 	* When dispose() was used to delete a ruby instance, the mapping between
--- branches/KDE/3.5/kdebindings/qtruby/rubylib/qtruby/Qt.cpp #486008:486009
@@ -1563,10 +1563,7 @@
     }
 
     VALUE result = rb_funcall2(qt_internal_module, rb_intern("try_initialize"), argc+1, temp_stack);
-
-    if (rb_respond_to(result, rb_intern("initialize")) != 0) {
 	rb_obj_call_init(result, argc, argv);
-    }
 	
 	free(temp_stack);
     return result;
_______________________________________________
Kde-bindings mailing list
Kde-bindings@kde.org
https://mail.kde.org/mailman/listinfo/kde-bindings
[prev in list] [next in list] [prev in thread] [next in thread]