[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-artists
Subject:    [kde-artists] [PATCH] Fix KDE 4.3 oxygen window border "chin"
From:       Jamboarder <jamboarder () yahoo ! com>
Date:       2009-08-08 5:06:27
Message-ID: 205953.96963.qm () web37308 ! mail ! mud ! yahoo ! com
[Download RAW message or body]

Hello,

I've attached a tiny patch for the oxygen window border to keep the side and bottom borders \
proportional over a greater range of border sizes.  The code comment suggested the bottom \
border is being fixed to a minimum of 7 pixels to maintain rounding.  This exceeds the default \
bottom border from KDE 4.2 and gives all windows, even for the default border size, a heavy \
looking "chin".  This also tends to make window items/widgets located in the bottom corners \
poorly balanced horizontally-to-vertically from the edges of the window.

The patch is very simple.  It just allows the bottom border to get little smaller.  There is no \
descernable effect the correct rounding of the bottom corners and the dotted grab handles \
remain visible.  For normal border sizes it also restores the balance that existed in KDE 4.2.

A pic is attached with the before and after.

Let me know if this patch is ok and I'll commit it.

Hope this helps,
Andrew Lake


["oxygenclient.diff" (text/x-patch)]

Index: oxygenclient.cpp
===================================================================
--- oxygenclient.cpp	(revision 998585)
+++ oxygenclient.cpp	(working copy)
@@ -143,7 +143,7 @@
                 // Even for thin borders (2px wide) we want to preserve
                 // the rounded corners having a minimum height of 7px
                 if (lm == LM_BorderBottom) {
-                    return qMax(frameWidth, 7);
+                    return qMax(frameWidth, 3);
                 } else {
                     return frameWidth;
                 }

["oxygenborderpatch.png" (image/png)]

______________________________________________________________________________
kde-artists@kde.org |  https://mail.kde.org/mailman/listinfo/kde-artists


[prev in list] [next in list] [prev in thread] [next in thread]