[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-artists
Subject:    Re: [kde-artists] phase style: bug 137055
From:       Matthew Woehlke <mw_triad () users ! sourceforge ! net>
Date:       2007-02-07 17:58:41
Message-ID: 45CA1351.5010403 () users ! sourceforge ! net
[Download RAW message or body]

David Johnson wrote:
> On Monday 05 February 2007 11:09, Matthew Woehlke wrote:
>> Any objections if I apply the patch in
>> http://bugs.kde.org/show_bug.cgi?id=137055
>> ?
> 
> My preferences is not to use text color, as that's too dark. For a 
> slightly more complex solution than your patch, one can create 
> a "branch" QColor that is mid() with an HSV value adjusted to be 
> between  base() and text(). This could be created in polish().

"Too dark"? On my color scheme, text() is /lighter/ than base() :-)

The problem is that mid() and base() are indistinguishable in some color
schemes. However, unless the user is just plain nuts, text() and base()
are pretty well guaranteed to be highly contrasting. (How were you
thinking to do this adjustment?)

Anyway, as you may note from the original comment, using text() was the
'fix of least resistance'. For Plastik (which has the same problem) the
patch I made (but haven't yet committed) uses Plastik's
alphaBlendColors() to pick a color in-between text() and base(). Another
possibility is contrast(base(), <amount>) where contrast(c,k) is
equivalent to darken(c,k) if c is lighter than medium gray and
lighten(c,k) if c is darker than medium gray. Or use your imagination.
The main point is that you have to adjust base() in a way that provides
contrast, and the only color you can really rely on to contrast with
base() is text().

(Note: in the style I wrote and use - which happens to be based on phase
:-) - I also use a blend of base() and text().)

Have I mentioned that KDE4 *really* needs a library function for color
blending?

-- 
Matthew
We interrupt this e-mail to bring you a lame signature attempting to be
witty.

______________________________________________________________________________
kde-artists@kde.org |  https://mail.kde.org/mailman/listinfo/kde-artists
[prev in list] [next in list] [prev in thread] [next in thread]