[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-active
Subject: Re: Review Request 122784: Fix 404 result for all api calls.
From: "Marco Martin" <notmart () gmail ! com>
Date: 2015-03-05 13:08:21
Message-ID: 20150305130821.6755.87133 () probe ! kde ! org
[Download RAW message or body]
--===============3938441876363286977==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122784/#review77055
-----------------------------------------------------------
Ship it!
Ship It!
- Marco Martin
On March 3, 2015, 3:21 a.m., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122784/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 3:21 a.m.)
>
>
> Review request for Bodega, kdelibs, Aaron J. Seigo, and Marco Martin.
>
>
> Repository: bodega-server
>
>
> Description
> -------
>
> Thanks to Johnathan for this fix.
>
>
> Diffs
> -----
>
> server/app.js 76c6f101a29a907a7af465d9f402770d84ab0e01
>
> Diff: https://git.reviewboard.kde.org/r/122784/diff/
>
>
> Testing
> -------
>
> Tests still fail but the api calls are returning json data now.
>
>
> Thanks,
>
> Jeremy Whiting
>
>
--===============3938441876363286977==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122784/">https://git.reviewboard.kde.org/r/122784/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Marco Martin</p>
<br />
<p>On March 3rd, 2015, 3:21 a.m. UTC, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Bodega, kdelibs, Aaron J. Seigo, and Marco Martin.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated March 3, 2015, 3:21 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
bodega-server
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Thanks to Johnathan for this fix.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tests still fail but the api calls are returning json \
data now.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>server/app.js <span style="color: \
grey">(76c6f101a29a907a7af465d9f402770d84ab0e01)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122784/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3938441876363286977==--
[Attachment #3 (text/plain)]
_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic