[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-active
Subject:    Re: Review Request 122552: warnings--
From:       Marco Martin <notmart () gmail ! com>
Date:       2015-02-13 20:33:02
Message-ID: CAD6_BotFk_MQpYR30++WUtgvPtKbvzaQubSDVsPE_Bp8hujuOA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


I did some tests.
the correct url is http://localhost:3000/bodega/v1/json/route  even tough
no routes seems to match

I can't figure out why, the only thing seems to be the express module to be
broken in some way.
probably good to make some tests with simple exampl-ish express apps


On Fri, Feb 13, 2015 at 2:17 PM, Jeremy Whiting <jpwhiting@kde.org> wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122552/
> This change has been marked as submitted.
> Review request for Bodega, kdelibs, Aaron J. Seigo, and Marco Martin.
> By Jeremy Whiting.
> 
> *Updated Feb. 13, 2015, 1:17 p.m.*
> *Repository: * bodega-server
> Description
> 
> warnings--
> 
> Testing
> 
> This fixes a  few more warnings seen at runtime, with this fix browsing to \
> localhost:3000/contact (or any other url in the api) shows the 404 page. Without \
> this fix it shows nothing and never responds. 
> Diffs
> 
> - server/app.js (4217a67735218e6bf1ccb04696a4e650319bb5d0)
> 
> View Diff <https://git.reviewboard.kde.org/r/122552/diff/>
> 


[Attachment #5 (text/html)]

<div dir="ltr">I did some tests.<div>the correct url is <a \
href="http://localhost:3000/bodega/v1/json/route">http://localhost:3000/bodega/v1/json/route</a> \
even tough no routes seems to match</div><div><br></div><div>I can&#39;t figure out \
why, the only thing seems to be the express module to be broken in some \
way.</div><div>probably good to make some tests with simple exampl-ish express \
apps</div><div><br></div></div><div class="gmail_extra"><br><div \
class="gmail_quote">On Fri, Feb 13, 2015 at 2:17 PM, Jeremy Whiting <span \
dir="ltr">&lt;<a href="mailto:jpwhiting@kde.org" \
target="_blank">jpwhiting@kde.org</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">



 <div>
  <div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><span class="">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border:1px #c9c399 \
solid;border-radius:6px">  <tbody><tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122552/" \
target="_blank">https://git.reviewboard.kde.org/r/122552/</a>  </td>
    </tr>
   </tbody></table>
   <br>



</span><table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border:1px gray \
solid;border-radius:6px">  <tbody><tr>
  <td>
   <h1 style="margin:0;padding:0;font-size:10pt">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</tbody></table>
<br>


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border:1px #888a85 solid;border-radius:6px">  <tbody><tr>
  <td><span class="">

<div>Review request for Bodega, kdelibs, Aaron J. Seigo, and Marco Martin.</div>
<div>By Jeremy Whiting.</div>


</span><p style="color:grey"><i>Updated Feb. 13, 2015, 1:17 p.m.</i></p><span \
class="">









<div style="margin-top:1.5em">
 <b style="color:#575012;font-size:10pt">Repository: </b>
bodega-server
</div>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0">  <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">warnings--</pre>
  </td>
 </tr>
</tbody></table>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0">  <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p \
style="padding:0;margin:0;line-height:inherit;white-space:inherit">This fixes a  few \
more warnings seen at runtime, with this fix browsing to localhost:3000/contact (or \
any other url in the api) shows the 404 page. Without this fix it shows nothing and \
never responds.</p></pre>  </td>
 </tr>
</tbody></table>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">

 <li>server/app.js <span \
style="color:grey">(4217a67735218e6bf1ccb04696a4e650319bb5d0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122552/diff/" style="margin-left:3em" \
target="_blank">View Diff</a></p>






  </span></td>
 </tr>
</tbody></table>



  </div>
 </div>


</blockquote></div><br></div>



_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active


[prev in list] [next in list] [prev in thread] [next in thread]