[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-active
Subject: Re: Review Request 121264: Remove call to app.use(app.router); as documented here:
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2014-11-27 11:02:12
Message-ID: 20141127110212.11305.55124 () probe ! kde ! org
[Download RAW message or body]
--===============5723637595776290850==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121264/#review71006
-----------------------------------------------------------
I have fixed the remaining issues and the server now starts again with express 4 .. \
will push shortly, including this patch. thanks!
- Aaron J. Seigo
On Nov. 27, 2014, 2:14 a.m., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121264/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2014, 2:14 a.m.)
>
>
> Review request for Bodega and Marco Martin.
>
>
> Repository: bodega-server
>
>
> Description
> -------
>
> Remove call to app.use(app.router); as documented here: \
> https://github.com/strongloop/express/wiki/Migrating-from-3.x-to-4.x
>
> Diffs
> -----
>
> server/app.js 98eaa74bf1e58202036ee8afef2c173dbfeee08f
>
> Diff: https://git.reviewboard.kde.org/r/121264/diff/
>
>
> Testing
> -------
>
> With this it doesn't give the error about app.router anymore. Still gives an error \
> on startup as follows though:
> body-parser deprecated bodyParser: use individual json/urlencoded middlewares \
> app.js:80:9 body-parser deprecated undefined extended: provide extended option \
> node_modules/body-parser/index.js:85:29 express-session deprecated undefined resave \
> option; provide resave option app.js:82:9 express-session deprecated undefined \
> saveUninitialized option; provide saveUninitialized option \
> app.js:82:9
> WARNING: Setting up server with no ssl!
> Bodega server listening on localhost:3000 in devel mode
>
> events.js:72
> throw er; // Unhandled 'error' event
> ^
> Error: connect ECONNREFUSED
> at errnoException (net.js:904:11)
> at Object.afterConnect [as oncomplete] (net.js:895:19)
>
>
> Thanks,
>
> Jeremy Whiting
>
>
--===============5723637595776290850==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121264/">https://git.reviewboard.kde.org/r/121264/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
have fixed the remaining issues and the server now starts again with express 4 .. \
will push shortly, including this patch. thanks!</p></pre> <br />
<p>- Aaron J. Seigo</p>
<br />
<p>On November 27th, 2014, 2:14 a.m. UTC, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Bodega and Marco Martin.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Nov. 27, 2014, 2:14 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
bodega-server
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Remove call to app.use(app.router); as documented \
here: https://github.com/strongloop/express/wiki/Migrating-from-3.x-to-4.x</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">With this it doesn't give the error about app.router \
anymore. Still gives an error on startup as follows though:</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">body-parser deprecated bodyParser: use individual json/urlencoded \
middlewares app.js:80:9 body-parser deprecated undefined extended: provide extended \
option node_modules/body-parser/index.js:85:29 express-session deprecated undefined \
resave option; provide resave option app.js:82:9 express-session deprecated undefined \
saveUninitialized option; provide saveUninitialized option \
app.js:82:9
WARNING: Setting up server with no ssl!
Bodega server listening on localhost:3000 in devel mode</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">events.js:72 throw er; // Unhandled 'error' event
^
Error: connect ECONNREFUSED
at errnoException (net.js:904:11)
at Object.afterConnect [as oncomplete] (net.js:895:19)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>server/app.js <span style="color: \
grey">(98eaa74bf1e58202036ee8afef2c173dbfeee08f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121264/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5723637595776290850==--
_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic