From kde-active Thu Nov 06 15:16:13 2014 From: "Giorgos Tsiapaliokas" Date: Thu, 06 Nov 2014 15:16:13 +0000 To: kde-active Subject: Re: Review Request 112965: add asset/forum/:assetId Message-Id: <20141106151613.9635.59904 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-active&m=141528700206828 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5904706171534455445==" --===============5904706171534455445== Content-Type: multipart/alternative; boundary="===============1691204475877116788==" --===============1691204475877116788== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112965/ ----------------------------------------------------------- (Updated Nov. 6, 2014, 5:16 p.m.) Status ------ This change has been discarded. Review request for Bodega. Repository: bodega-server Description ------- Add a new route which returns the messages from the forum. The json looks like this { "authStatus": true, "device": "KDE-1", "store": "KDE-1", "points": 10000, "success": true, "topics": [ { "title": "Foo bar linux12342425", "message": "

foo bar linux123423235235235

" }, { "title": "Foo bar linux123424566", "message": "

foo bar linux1234578896666

" }, { "title": "Foo bar linux1234245", "message": "

foo bar linux12342245

" }, { "title": "Foo bar linux1234", "message": "

foo bar linux1234566

" }, { "title": "Foo bar ioanna maria 1foo bar ioanna maria 1adsasd", "message": "

88971238912389()(()DAS()A*(DS()ADS(()ADS908foo bar ioanna maria 1foo bar ioanna maria 1foo bar ioanna maria 1foo bar ioanna maria 1

" } ] } Diffs ----- .gitignore 6b01f0d README 164e0d8 assetimporters/CMakeLists.txt 369626f assetimporters/common/database.h b66c4b2 assetimporters/common/database.cpp edf8526 assetimporters/projectgutenberg/src/catalog.cpp e5c8483 assetimporters/projectgutenberg/src/ebook.cpp 2eea13b assetimporters/projectgutenberg/src/gutenbergdatabase.h 6c7a02c assetimporters/projectgutenberg/src/gutenbergdatabase.cpp b8fa3c7 assetimporters/projectgutenberg/src/main.cpp 6ec658b server/.jshintignore 23ededc server/Makefile 2f8082d server/TODO 1a314ba server/app.js da49ccb server/assetRules.js 2dca3ee server/bodegaDbHelper 759bc82 server/config.json.sample c691247 server/doc/bodega.json a08746f server/lib/assetstore.js d3f1887 server/lib/bodegadb.js a1063fe server/lib/db/assetinfo.js c365a0d server/lib/db/assetmanager.js 0532323 server/lib/db/authorize.js 7021c18 server/lib/db/banking.js 87e3825 server/lib/db/changeAccountDetails.js 2bd965c server/lib/db/channels.js b5a76ef server/lib/db/createutils.js dae5ed3 server/lib/db/deleteasset.js e73374a server/lib/db/download.js 91fe9c9 server/lib/db/easterEggHunt.js a3946ea server/lib/db/forum.js PRE-CREATION server/lib/db/listassets.js 3656657 server/lib/db/partners.js b767b7d server/lib/db/partnersrequests.js 918fae9 server/lib/db/points.js b3c8096 server/lib/db/postasset.js 5a26a80 server/lib/db/publishasset.js 02555d4 server/lib/db/purchaseAsset.js f39cfed server/lib/db/ratings.js 95f38c9 server/lib/db/resetrequest.js 681ddf7 server/lib/db/tags.js 6624d0f server/lib/errors.js ccf3ebb server/lib/janitor.js 6e7e2ef server/lib/messengers/participant_accountActivation.js 9bdad18 server/lib/messengers/participant_passwordReset.js b94be12 server/lib/messengers/partner_distributorRequest.js 6b6c0f8 server/lib/messengers/partner_distributorRequestAccept.handlebars.text ce69337 server/lib/messengers/partner_distributorRequestAccept.js 462479f server/lib/messengers/partner_distributorRequestReject.handlebars.text a6495e0 server/lib/messengers/partner_distributorRequestReject.js 4c1db67 server/lib/messengers/partner_distributor_assetRejection.handlebars.text 9fc3980 server/lib/messengers/partner_distributor_assetRejection.js 744a23a server/lib/messengers/partner_publisherRequest.js 4061966 server/lib/messengers/partner_publisherRequestAccept.handlebars.text b408795 server/lib/messengers/partner_publisherRequestAccept.js 84690ab server/lib/messengers/partner_publisherRequestReject.handlebars.text d71341a server/lib/messengers/partner_publisherRequestReject.js 4284c88 server/lib/payments.js 8e9e533 server/lib/previewstore.js 5776789 server/lib/roles.js 6977dac server/lib/utils.js 68ee31e server/main.sh ed37222 server/package.json ce291b5 server/public/icons/128/default/application.png 61e8da4 server/public/icons/22/default/application.png e68dc68 server/public/icons/256/default/application.png 26c352a server/public/icons/256/default/wallpaper.png 63ea63f server/public/icons/32/default/application.png d4afdd4 server/public/icons/512/default/application.png fb0d8f2 server/public/icons/512/default/wallpaper.png 1c58400 server/public/icons/64/default/application.png 5c36c08 server/routes.js 3b0849f server/test/accounts.js 128ef39 server/test/api.js 7ee3d53 server/test/assetcreation.js a57e3e3 server/test/auth.js ddf1119 server/test/forum.js PRE-CREATION server/test/partners.js 880e899 server/test/points.js b2bf66f server/test/previewstore.js 0d95713 server/test/purchase.js 991cf65 server/test/ratings.js 15e4e63 server/test/sampleasset/sample-app-info.json b09e9c1 server/test/support/utils.js bbe02d3 server/test/tags.js 66c45e6 server/views/passwordreset.jade aed8095 sql/api.plsql 27816a3 sql/core.plsql 137083d sql/core.sql 1fa61f2 sql/defaultdata.sql 6d0d0c9 sql/discourse.plsql 02bee9c sql/discourse.sql cbd8b87 sql/maintenance.plsql 3d2dac8 sql/purchasing.plsql eebfa25 sql/ratings.plsql 1f9451d sql/search_en.plsql e2456a2 sql/testdata.sql 33fe2b9 sql/vivaldi.sql c6a0d5c Diff: https://git.reviewboard.kde.org/r/112965/diff/ Testing ------- $ make test/forum ./node_modules/.bin/mocha test/forum.js --reporter spec WARNING: Setting up server with no ssl! Bodega server listening on localhost:3001 in devel mode Forum Authorization ? succeeds (75ms) List Messages ? should fail because the asset is invalid ? should succeed (3313ms) <------------------------------------------------------ Probably something is wrong here. It takes 3 seconds and both bodega-server and the forum are in localhost. I did this.timeout(15000) in order to pass the test 3 passing (3 seconds) Thanks, Giorgos Tsiapaliokas --===============1691204475877116788== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112965/

This change has been discarded.


Review request for Bodega.
By Giorgos Tsiapaliokas.

Updated Nov. 6, 2014, 5:16 p.m.

Repository: bodega-server

Description

Add a new route which returns the messages from the forum.
The json looks like this

{
  "authStatus": true,
  "device": "KDE-1",
  "store": "KDE-1",
  "points": 10000,
  "success": true,
  "topics": [
    {
      "title": "Foo bar linux12342425",
      "message": "<p>foo bar linux123423235235235</p>"
    },
    {
      "title": "Foo bar linux123424566",
      "message": "<p>foo bar linux1234578896666</p>"
    },
    {
      "title": "Foo bar linux1234245",
      "message": "<p>foo bar linux12342245</p>"
    },
    {
      "title": "Foo bar linux1234",
      "message": "<p>foo bar linux1234566</p>"
    },
    {
      "title": "Foo bar ioanna maria 1foo bar ioanna maria 1adsasd",
      "message": "<p>88971238912389()(<em>()DAS</em>()A*(DS()<em>ADS(</em>()ADS908foo bar ioanna maria 1foo bar ioanna maria 1foo bar ioanna maria 1foo bar ioanna maria 1</p>"
    }
  ]
}

Testing

$ make test/forum
./node_modules/.bin/mocha test/forum.js --reporter spec
WARNING: Setting up server with no ssl!
Bodega server listening on localhost:3001 in devel mode


  Forum
    Authorization
      ? succeeds (75ms)
    List Messages
      ? should fail because the asset is invalid 
      ? should succeed (3313ms) <------------------------------------------------------ Probably something is wrong here. It takes 3 seconds and both bodega-server and the forum are in localhost.
                                                                                        I did this.timeout(15000) in order to pass the test

  3 passing (3 seconds)

Diffs

  • .gitignore (6b01f0d)
  • README (164e0d8)
  • assetimporters/CMakeLists.txt (369626f)
  • assetimporters/common/database.h (b66c4b2)
  • assetimporters/common/database.cpp (edf8526)
  • assetimporters/projectgutenberg/src/catalog.cpp (e5c8483)
  • assetimporters/projectgutenberg/src/ebook.cpp (2eea13b)
  • assetimporters/projectgutenberg/src/gutenbergdatabase.h (6c7a02c)
  • assetimporters/projectgutenberg/src/gutenbergdatabase.cpp (b8fa3c7)
  • assetimporters/projectgutenberg/src/main.cpp (6ec658b)
  • server/.jshintignore (23ededc)
  • server/Makefile (2f8082d)
  • server/TODO (1a314ba)
  • server/app.js (da49ccb)
  • server/assetRules.js (2dca3ee)
  • server/bodegaDbHelper (759bc82)
  • server/config.json.sample (c691247)
  • server/doc/bodega.json (a08746f)
  • server/lib/assetstore.js (d3f1887)
  • server/lib/bodegadb.js (a1063fe)
  • server/lib/db/assetinfo.js (c365a0d)
  • server/lib/db/assetmanager.js (0532323)
  • server/lib/db/authorize.js (7021c18)
  • server/lib/db/banking.js (87e3825)
  • server/lib/db/changeAccountDetails.js (2bd965c)
  • server/lib/db/channels.js (b5a76ef)
  • server/lib/db/createutils.js (dae5ed3)
  • server/lib/db/deleteasset.js (e73374a)
  • server/lib/db/download.js (91fe9c9)
  • server/lib/db/easterEggHunt.js (a3946ea)
  • server/lib/db/forum.js (PRE-CREATION)
  • server/lib/db/listassets.js (3656657)
  • server/lib/db/partners.js (b767b7d)
  • server/lib/db/partnersrequests.js (918fae9)
  • server/lib/db/points.js (b3c8096)
  • server/lib/db/postasset.js (5a26a80)
  • server/lib/db/publishasset.js (02555d4)
  • server/lib/db/purchaseAsset.js (f39cfed)
  • server/lib/db/ratings.js (95f38c9)
  • server/lib/db/resetrequest.js (681ddf7)
  • server/lib/db/tags.js (6624d0f)
  • server/lib/errors.js (ccf3ebb)
  • server/lib/janitor.js (6e7e2ef)
  • server/lib/messengers/participant_accountActivation.js (9bdad18)
  • server/lib/messengers/participant_passwordReset.js (b94be12)
  • server/lib/messengers/partner_distributorRequest.js (6b6c0f8)
  • server/lib/messengers/partner_distributorRequestAccept.handlebars.text (ce69337)
  • server/lib/messengers/partner_distributorRequestAccept.js (462479f)
  • server/lib/messengers/partner_distributorRequestReject.handlebars.text (a6495e0)
  • server/lib/messengers/partner_distributorRequestReject.js (4c1db67)
  • server/lib/messengers/partner_distributor_assetRejection.handlebars.text (9fc3980)
  • server/lib/messengers/partner_distributor_assetRejection.js (744a23a)
  • server/lib/messengers/partner_publisherRequest.js (4061966)
  • server/lib/messengers/partner_publisherRequestAccept.handlebars.text (b408795)
  • server/lib/messengers/partner_publisherRequestAccept.js (84690ab)
  • server/lib/messengers/partner_publisherRequestReject.handlebars.text (d71341a)
  • server/lib/messengers/partner_publisherRequestReject.js (4284c88)
  • server/lib/payments.js (8e9e533)
  • server/lib/previewstore.js (5776789)
  • server/lib/roles.js (6977dac)
  • server/lib/utils.js (68ee31e)
  • server/main.sh (ed37222)
  • server/package.json (ce291b5)
  • server/public/icons/128/default/application.png (61e8da4)
  • server/public/icons/22/default/application.png (e68dc68)
  • server/public/icons/256/default/application.png (26c352a)
  • server/public/icons/256/default/wallpaper.png (63ea63f)
  • server/public/icons/32/default/application.png (d4afdd4)
  • server/public/icons/512/default/application.png (fb0d8f2)
  • server/public/icons/512/default/wallpaper.png (1c58400)
  • server/public/icons/64/default/application.png (5c36c08)
  • server/routes.js (3b0849f)
  • server/test/accounts.js (128ef39)
  • server/test/api.js (7ee3d53)
  • server/test/assetcreation.js (a57e3e3)
  • server/test/auth.js (ddf1119)
  • server/test/forum.js (PRE-CREATION)
  • server/test/partners.js (880e899)
  • server/test/points.js (b2bf66f)
  • server/test/previewstore.js (0d95713)
  • server/test/purchase.js (991cf65)
  • server/test/ratings.js (15e4e63)
  • server/test/sampleasset/sample-app-info.json (b09e9c1)
  • server/test/support/utils.js (bbe02d3)
  • server/test/tags.js (66c45e6)
  • server/views/passwordreset.jade (aed8095)
  • sql/api.plsql (27816a3)
  • sql/core.plsql (137083d)
  • sql/core.sql (1fa61f2)
  • sql/defaultdata.sql (6d0d0c9)
  • sql/discourse.plsql (02bee9c)
  • sql/discourse.sql (cbd8b87)
  • sql/maintenance.plsql (3d2dac8)
  • sql/purchasing.plsql (eebfa25)
  • sql/ratings.plsql (1f9451d)
  • sql/search_en.plsql (e2456a2)
  • sql/testdata.sql (33fe2b9)
  • sql/vivaldi.sql (c6a0d5c)

View Diff

--===============1691204475877116788==-- --===============5904706171534455445== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Active mailing list Active@kde.org https://mail.kde.org/mailman/listinfo/active --===============5904706171534455445==--