'Re: Review Request 112899: add support for the forum in bodega-client(1 of 2)'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-active
Subject:    Re: Review Request 112899: add support for the forum in bodega-client(1 of 2)
From:       "Giorgos Tsiapaliokas" <giorgos.tsiapaliokas () kde ! org>
Date:       2014-11-06 15:16:13
Message-ID: 20141106151613.9635.51776 () probe ! kde ! org
[Download RAW message or body]

--===============8541308481957413872==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112899/
-----------------------------------------------------------

(Updated Nov. 6, 2014, 5:16 p.m.)

Status
------

This change has been discarded.

Review request for Bodega.

Repository: bodega-client

Description
-------

This patch adds the forumjob and the forumjobmodel.
The patch doesn't contain any ui bits in order to avoid
an endless review request. I will open the second one after this one.

Diffs
-----

  lib/bodega/CMakeLists.txt 6fd0d0b 
  lib/bodega/assetjob.cpp 3423c41 
  lib/bodega/assetoperations.h c4ce191 
  lib/bodega/assetoperations.cpp b1fd346 
  lib/bodega/forumjob_p.h PRE-CREATION 
  lib/bodega/forumjob_p.cpp PRE-CREATION 
  lib/bodega/forumjobmodel_p.h PRE-CREATION 
  lib/bodega/forumjobmodel_p.cpp PRE-CREATION 
  lib/bodega/globals.h c696a40 

Diff: https://git.reviewboard.kde.org/r/112899/diff/

Testing
-------

It builds.

Thanks,

Giorgos Tsiapaliokas

--===============8541308481957413872==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/112899/">https://git.reviewboard.kde.org/r/112899/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated Nov. 6, 2014, 5:16 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
bodega-client
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds the forumjob and the forumjobmodel. The patch \
doesn&#39;t contain any ui bits in order to avoid an endless review request. I will \
open the second one after this one. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It builds. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>lib/bodega/CMakeLists.txt <span style="color: grey">(6fd0d0b)</span></li>

 <li>lib/bodega/assetjob.cpp <span style="color: grey">(3423c41)</span></li>

 <li>lib/bodega/assetoperations.h <span style="color: grey">(c4ce191)</span></li>

 <li>lib/bodega/assetoperations.cpp <span style="color: grey">(b1fd346)</span></li>

 <li>lib/bodega/forumjob_p.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lib/bodega/forumjob_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lib/bodega/forumjobmodel_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>lib/bodega/forumjobmodel_p.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>lib/bodega/globals.h <span style="color: grey">(c696a40)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/112899/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8541308481957413872==--

_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

[prev in list] [next in list] [prev in thread] [next in thread] 