From kde-active Mon Sep 23 15:32:00 2013 From: "Giorgos Tsiapaliokas" Date: Mon, 23 Sep 2013 15:32:00 +0000 To: kde-active Subject: Re: Review Request 112581: add support for the forum API Message-Id: <20130923153200.2644.51372 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-active&m=137995034824336 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6971317221508732066==" --===============6971317221508732066== Content-Type: multipart/alternative; boundary="===============2816487349604427102==" --===============2816487349604427102== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112581/ ----------------------------------------------------------- (Updated Sept. 23, 2013, 3:31 p.m.) Status ------ This change has been discarded. Review request for Bodega. Description ------- This patch * parses the forum info from asset/:assetId * adds a button in the ui in order to open the link in the browser Diffs ----- activeclient/package/contents/ui/storebrowser/AssetColumn.qml a678f16 activeclient/src/bodegastore.cpp ba9dc27 lib/bodega/assetjob.cpp 5f539cb lib/bodega/globals.h 5ab45da Diff: http://git.reviewboard.kde.org/r/112581/diff/ Testing ------- attached screenshot File Attachments ---------------- http://git.reviewboard.kde.org/media/uploaded/files/2013/09/07/forumbutton.png Thanks, Giorgos Tsiapaliokas --===============2816487349604427102== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112581/

This change has been discarded.

Review request for Bodega.
By Giorgos Tsiapaliokas.

Updated Sept. 23, 2013, 3:31 p.m.

Description 

This patch
* parses the forum info from asset/:assetId
* adds a button in the ui in order to open the link in the browser

Testing 

attached screenshot

Diffs

  • activeclient/package/contents/ui/storebrowser/AssetColumn.qml (a678f16)
  • activeclient/src/bodegastore.cpp (ba9dc27)
  • lib/bodega/assetjob.cpp (5f539cb)
  • lib/bodega/globals.h (5ab45da)

View Diff

File Attachments

--===============2816487349604427102==-- --===============6971317221508732066== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Active mailing list Active@kde.org https://mail.kde.org/mailman/listinfo/active --===============6971317221508732066==--