[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-active
Subject: Re: Review Request 112533: add ratings in the bodega-client
From: "Commit Hook" <null () kde ! org>
Date: 2013-09-20 15:31:44
Message-ID: 20130920153144.27706.85762 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112533/
-----------------------------------------------------------
(Updated Sept. 20, 2013, 3:31 p.m.)
Status
------
This change has been marked as submitted.
Review request for Bodega.
Description
-------
This patch implements the ratings feature
Diffs
-----
activeclient/package/contents/ui/storebrowser/RatingsColumn.qml PRE-CREATION
activeclient/package/contents/ui/storebrowser/Ratings.js PRE-CREATION
activeclient/package/contents/ui/storebrowser/AssetColumn.qml a678f16
activeclient/package/contents/ui/settings/ParticipantRatings.qml PRE-CREATION
activeclient/package/contents/ui/SettingsPage.qml fb46eca
activeclient/src/bodegastore.h 1e5aac5
activeclient/src/bodegastore.cpp ba9dc27
lib/bodega/CMakeLists.txt 8d382a7
lib/bodega/assetjob.h 5aab88c
lib/bodega/assetjob.cpp 5f539cb
lib/bodega/assetoperations.h 7ce7900
lib/bodega/assetoperations.cpp 9f9c2d5
lib/bodega/assetratingsjob.h PRE-CREATION
lib/bodega/assetratingsjob.cpp PRE-CREATION
lib/bodega/assetratingsjobmodel.h PRE-CREATION
lib/bodega/assetratingsjobmodel.cpp PRE-CREATION
lib/bodega/globals.h 5ab45da
lib/bodega/participantratingsjob.h PRE-CREATION
lib/bodega/participantratingsjob.cpp PRE-CREATION
lib/bodega/participantratingsjobmodel.h PRE-CREATION
lib/bodega/participantratingsjobmodel.cpp PRE-CREATION
lib/bodega/ratingattributesjob.h PRE-CREATION
lib/bodega/ratingattributesjob.cpp PRE-CREATION
lib/bodega/ratingsmodel_p.h PRE-CREATION
lib/bodega/ratingsmodel_p.cpp PRE-CREATION
lib/bodega/session.h d27d284
lib/bodega/session.cpp a7c7e94
lib/bodega/session_p.h ebefb4f
Diff: http://git.reviewboard.kde.org/r/112533/diff/
Testing
-------
check the attached images
File Attachments
----------------
http://git.reviewboard.kde.org/media/uploaded/files/2013/09/05/ratings-main.png
http://git.reviewboard.kde.org/media/uploaded/files/2013/09/05/participantratings.png
http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/labelsnotcenter.png
http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/delete2.png
http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/brokenParticipant.diff
http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/participantbroken.png
Thanks,
Giorgos Tsiapaliokas
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112533/">http://git.reviewboard.kde.org/r/112533/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Sept. 20, 2013, 3:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch implements the ratings \
feature</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">check the attached images</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>activeclient/package/contents/ui/storebrowser/RatingsColumn.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>activeclient/package/contents/ui/storebrowser/Ratings.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>activeclient/package/contents/ui/storebrowser/AssetColumn.qml <span style="color: \
grey">(a678f16)</span></li>
<li>activeclient/package/contents/ui/settings/ParticipantRatings.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>activeclient/package/contents/ui/SettingsPage.qml <span style="color: grey">(fb46eca)</span></li>
<li>activeclient/src/bodegastore.h <span style="color: grey">(1e5aac5)</span></li>
<li>activeclient/src/bodegastore.cpp <span style="color: grey">(ba9dc27)</span></li>
<li>lib/bodega/CMakeLists.txt <span style="color: grey">(8d382a7)</span></li>
<li>lib/bodega/assetjob.h <span style="color: grey">(5aab88c)</span></li>
<li>lib/bodega/assetjob.cpp <span style="color: grey">(5f539cb)</span></li>
<li>lib/bodega/assetoperations.h <span style="color: grey">(7ce7900)</span></li>
<li>lib/bodega/assetoperations.cpp <span style="color: grey">(9f9c2d5)</span></li>
<li>lib/bodega/assetratingsjob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/bodega/assetratingsjob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/bodega/assetratingsjobmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/bodega/assetratingsjobmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/bodega/globals.h <span style="color: grey">(5ab45da)</span></li>
<li>lib/bodega/participantratingsjob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/bodega/participantratingsjob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/bodega/participantratingsjobmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/bodega/participantratingsjobmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/bodega/ratingattributesjob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/bodega/ratingattributesjob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/bodega/ratingsmodel_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/bodega/ratingsmodel_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/bodega/session.h <span style="color: grey">(d27d284)</span></li>
<li>lib/bodega/session.cpp <span style="color: grey">(a7c7e94)</span></li>
<li>lib/bodega/session_p.h <span style="color: grey">(ebefb4f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112533/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/05/ratings-main.png">ratings-main.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/05/participantratings.png">participantratings.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/labelsnotcenter.png">labelsnotcenter.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/delete2.png">delete2.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/brokenParticipant.diff">brokenParticipant.diff</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/participantbroken.png">participantbroken.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic