[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-active
Subject: Re: Review Request 112581: add support for the forum API
From: "Giorgos Tsiapaliokas" <terietor () gmail ! com>
Date: 2013-09-14 11:48:10
Message-ID: 20130914114810.5287.52967 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Sept. 12, 2013, 3:52 p.m., Aaron J. Seigo wrote:
> > a button that opens a web browser to the forum page makes the application not \
> > self-hosting and very clumsy from a navigational POV (how do you get back to the \
> > client? pull down the peek area, close the browser and go back to the add-ons \
> > client? ugh)
> > rather, as discussed, it would be better to be able to show the last N (say, 5) \
> > comments in the assets info panel. as with reviews, it might make sense to have a \
> > link that says "See what people are saying.." or even just "See feedback..." \
> > which would then hide that link and expand to show the last N comments.
> > this itself could be done in one of two ways: either show the comments in the \
> > info pane itself or, and this is my preference atm, open a new column showing the \
> > feedback. that panel could then have a "Open the forum..." link that would open a \
> > web browser and which would be used to interact with the forum.
> > additionally, on the "rate and review" popup used to add / edit ratings, there \
> > should be a text area in which the user can put some text as a review which then \
> > gets added to the forum
> > really, the web forum part is only for the developer to continue interacting with \
> > the feedback and for people who wish to get more involved in the conversation to \
> > do so. but the Add Ons app itself should provide a basic display the feedback \
> > from the forum without leaving the add-ons app.
> and this is my preference atm, open a new column showing the feedback
ok, lets create a new column then.
> to be able to show the last N (say, 5) comments
I don't understand what to add in the column. If we have the asset 'Poker 11' there \
will be a category for the asset 'Poker 11' which will have topics which may have >=0 \
posts. So, don't we need a column which will show the topics of the asset 'Poker 11' \
and *another* column which will show the posts (if any) of the specified topic?
Also we need some Qt code for the discourse API, where should I put it? In libbodega \
or in another library?
- Giorgos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112581/#review39893
-----------------------------------------------------------
On Sept. 7, 2013, 5:46 p.m., Giorgos Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112581/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2013, 5:46 p.m.)
>
>
> Review request for Bodega.
>
>
> Description
> -------
>
> This patch
> * parses the forum info from asset/:assetId
> * adds a button in the ui in order to open the link in the browser
>
>
> Diffs
> -----
>
> activeclient/package/contents/ui/storebrowser/AssetColumn.qml a678f16
> activeclient/src/bodegastore.cpp ba9dc27
> lib/bodega/assetjob.cpp 5f539cb
> lib/bodega/globals.h 5ab45da
>
> Diff: http://git.reviewboard.kde.org/r/112581/diff/
>
>
> Testing
> -------
>
> attached screenshot
>
>
> File Attachments
> ----------------
>
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/07/forumbutton.png
>
>
> Thanks,
>
> Giorgos Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112581/">http://git.reviewboard.kde.org/r/112581/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 12th, 2013, 3:52 p.m. UTC, <b>Aaron \
J. Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">a button that opens a web browser to the forum page makes the \
application not self-hosting and very clumsy from a navigational POV (how do you get \
back to the client? pull down the peek area, close the browser and go back to the \
add-ons client? ugh)
rather, as discussed, it would be better to be able to show the last N (say, 5) \
comments in the assets info panel. as with reviews, it might make sense to have a \
link that says "See what people are saying.." or even just "See \
feedback..." which would then hide that link and expand to show the last N \
comments.
this itself could be done in one of two ways: either show the comments in the info \
pane itself or, and this is my preference atm, open a new column showing the \
feedback. that panel could then have a "Open the forum..." link that would \
open a web browser and which would be used to interact with the forum.
additionally, on the "rate and review" popup used to add / edit ratings, \
there should be a text area in which the user can put some text as a review which \
then gets added to the forum
really, the web forum part is only for the developer to continue interacting with the \
feedback and for people who wish to get more involved in the conversation to do so. \
but the Add Ons app itself should provide a basic display the feedback from the forum \
without leaving the add-ons app.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> and this is my \
preference atm, open a new column showing the feedback
ok, lets create a new column then.
> to be able to show the last N (say, 5) comments
I don't understand what to add in the column. If we have the asset 'Poker \
11' there will be a category for the asset 'Poker 11' which will have \
topics which may have >=0 posts. So, don't we need a column which will show \
the topics of the asset 'Poker 11' and *another* column which will show the \
posts (if any) of the specified topic?
Also we need some Qt code for the discourse API, where should I put it? In libbodega \
or in another library?</pre> <br />
<p>- Giorgos</p>
<br />
<p>On September 7th, 2013, 5:46 p.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Sept. 7, 2013, 5:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch
* parses the forum info from asset/:assetId
* adds a button in the ui in order to open the link in the browser</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">attached screenshot </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>activeclient/package/contents/ui/storebrowser/AssetColumn.qml <span \
style="color: grey">(a678f16)</span></li>
<li>activeclient/src/bodegastore.cpp <span style="color: grey">(ba9dc27)</span></li>
<li>lib/bodega/assetjob.cpp <span style="color: grey">(5f539cb)</span></li>
<li>lib/bodega/globals.h <span style="color: grey">(5ab45da)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112581/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/07/forumbutton.png">forumbutton.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic