'Re: Review Request 112095: add asset/participant/ratings/:assetId'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-active
Subject:    Re: Review Request 112095: add asset/participant/ratings/:assetId
From:       "Giorgos Tsiapaliokas" <terietor () gmail ! com>
Date:       2013-09-02 16:56:55
Message-ID: 20130902165655.16423.95374 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112095/
-----------------------------------------------------------

(Updated Sept. 2, 2013, 4:56 p.m.)

Review request for Bodega.

Changes
-------

Ok I have fixed the issue.
So we have a new route named participant/ratings/:assetId?

push??

Description
-------

This patch adds the route asset/participant/ratings/:assetId
which gives us the user's ratings for a specific asset.

Diffs (updated)
-----

  server/doc/bodega.json 3efd1cf 
  server/lib/bodegadb.js 20a8ef8 
  server/lib/db/ratings.js e5f4bed 
  server/routes.js 903c9a3 
  server/test/ratings.js 8538e86 

Diff: http://git.reviewboard.kde.org/r/112095/diff/

Testing
-------

the tests are passing

Thanks,

Giorgos Tsiapaliokas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112095/">http://git.reviewboard.kde.org/r/112095/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated Sept. 2, 2013, 4:56 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ok I have fixed the issue. So we have a new route named \
participant/ratings/:assetId?

push??</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds the route asset/participant/ratings/:assetId which gives \
us the user&#39;s ratings for a specific asset.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">the tests are passing </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>server/doc/bodega.json <span style="color: grey">(3efd1cf)</span></li>

 <li>server/lib/bodegadb.js <span style="color: grey">(20a8ef8)</span></li>

 <li>server/lib/db/ratings.js <span style="color: grey">(e5f4bed)</span></li>

 <li>server/routes.js <span style="color: grey">(903c9a3)</span></li>

 <li>server/test/ratings.js <span style="color: grey">(8538e86)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112095/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

[prev in list] [next in list] [prev in thread] [next in thread] 