--===============0455570302308360013== Content-Type: multipart/alternative; boundary="===============8721191807955067546==" --===============8721191807955067546== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Aug. 19, 2013, 8:27 p.m., Aaron J. Seigo wrote: > > server/routes.js, line 365 > > > > > > this should be merged with asset/participant/ratings above as: > > > > 'asset/participant/ratings/:assetId?' > > > > this makes it consistent with other similar routes that optionally take a asset or other id that narrows the result set down. > > > > see the 'collection/list/:collectionId?' route for a pattern to follow >this should be merged with asset/participant/ratings above as do you mean that 'asset/participant/ratings/:assetId' should be merged with 'participant/ratings' into 'asset/participant/ratings/:assetId?'? I can't find the route 'asset/participant/rating'. - Giorgos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112095/#review38170 ----------------------------------------------------------- On Aug. 15, 2013, 7:11 a.m., Giorgos Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112095/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2013, 7:11 a.m.) > > > Review request for Bodega. > > > Description > ------- > > This patch adds the route asset/participant/ratings/:assetId > which gives us the user's ratings for a specific asset. > > > Diffs > ----- > > server/doc/bodega.json 3efd1cf > server/lib/bodegadb.js 20a8ef8 > server/lib/db/ratings.js e5f4bed > server/routes.js 903c9a3 > server/test/ratings.js 8538e86 > > Diff: http://git.reviewboard.kde.org/r/112095/diff/ > > > Testing > ------- > > the tests are passing > > > Thanks, > > Giorgos Tsiapaliokas > > --===============8721191807955067546== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112095/

On August 19th, 2013, 8:27 p.m. UTC, Aaron J. Seigo wrote:

server/routes.js (Diff revision 1)
function serverPath(path)
		365	app.get(serverPath('asset/participant/ratings/:assetId'), isAuthorized,

this should be merged with asset/participant/ratings above as:

'asset/participant/ratings/:assetId?'

this makes it consistent with other similar routes that optionally take a asset or other id that narrows the result set down.

see the 'collection/list/:collectionId?' route for a pattern to follow

>this should be merged with asset/participant/ratings above as

do you mean that 'asset/participant/ratings/:assetId' should be merged with 'participant/ratings'
into 'asset/participant/ratings/:assetId?'? I can't find the route 'asset/participant/rating'.

- Giorgos

On August 15th, 2013, 7:11 a.m. UTC, Giorgos Tsiapaliokas wrote:

Review request for Bodega.

By Giorgos Tsiapaliokas.

Updated Aug. 15, 2013, 7:11 a.m.

Description

This patch adds the route asset/participant/ratings/:assetId
which gives us the user's ratings for a specific asset.

Testing

the tests are passing

Diffs

server/doc/bodega.json (3efd1cf)
server/lib/bodegadb.js (20a8ef8)
server/lib/db/ratings.js (e5f4bed)
server/routes.js (903c9a3)
server/test/ratings.js (8538e86)

--===============8721191807955067546==-- --===============0455570302308360013== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Active mailing list Active@kde.org https://mail.kde.org/mailman/listinfo/active --===============0455570302308360013==--