This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112095/

On August 19th, 2013, 8:27 p.m. UTC, Aaron J. Seigo wrote:

server/routes.js (Diff revision 1)
function serverPath(path)
365
app.get(serverPath('asset/participant/ratings/:assetId'), isAuthorized,
this should be merged with asset/participant/ratings above as:

'asset/participant/ratings/:assetId?'

this makes it consistent with other similar routes that optionally take a asset or other id that narrows the result set down.

see the 'collection/list/:collectionId?' route for a pattern to follow
>this should be merged with asset/participant/ratings above as

do you mean that 'asset/participant/ratings/:assetId' should be merged with 'participant/ratings'
into 'asset/participant/ratings/:assetId?'? I can't find the route 'asset/participant/rating'.

- Giorgos


On August 15th, 2013, 7:11 a.m. UTC, Giorgos Tsiapaliokas wrote:

Review request for Bodega.
By Giorgos Tsiapaliokas.

Updated Aug. 15, 2013, 7:11 a.m.

Description

This patch adds the route asset/participant/ratings/:assetId
which gives us the user's ratings for a specific asset.

Testing

the tests are passing

Diffs

  • server/doc/bodega.json (3efd1cf)
  • server/lib/bodegadb.js (20a8ef8)
  • server/lib/db/ratings.js (e5f4bed)
  • server/routes.js (903c9a3)
  • server/test/ratings.js (8538e86)

View Diff