[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-active
Subject: Re: Review Request 112095: add asset/participant/ratings/:assetId
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2013-08-19 20:27:49
Message-ID: 20130819202749.15615.52362 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112095/#review38170
-----------------------------------------------------------
server/lib/db/ratings.js
<http://git.reviewboard.kde.org/r/112095/#comment28219>
ASSET is not an SQL keyword; should therefore be lowercase
server/lib/db/ratings.js
<http://git.reviewboard.kde.org/r/112095/#comment28220>
this should be moved to line 137 (it's unused in the case of an error, so don't \
spend CPU cycles creating it)
server/lib/db/ratings.js
<http://git.reviewboard.kde.org/r/112095/#comment28221>
should be using utils.parseNumber and checking for > 0 in the if statement below
server/routes.js
<http://git.reviewboard.kde.org/r/112095/#comment28218>
this should be merged with asset/participant/ratings above as:
'asset/participant/ratings/:assetId?'
this makes it consistent with other similar routes that optionally take a asset \
or other id that narrows the result set down.
see the 'collection/list/:collectionId?' route for a pattern to follow
- Aaron J. Seigo
On Aug. 15, 2013, 7:11 a.m., Giorgos Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112095/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2013, 7:11 a.m.)
>
>
> Review request for Bodega.
>
>
> Description
> -------
>
> This patch adds the route asset/participant/ratings/:assetId
> which gives us the user's ratings for a specific asset.
>
>
> Diffs
> -----
>
> server/doc/bodega.json 3efd1cf
> server/lib/bodegadb.js 20a8ef8
> server/lib/db/ratings.js e5f4bed
> server/routes.js 903c9a3
> server/test/ratings.js 8538e86
>
> Diff: http://git.reviewboard.kde.org/r/112095/diff/
>
>
> Testing
> -------
>
> the tests are passing
>
>
> Thanks,
>
> Giorgos Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112095/">http://git.reviewboard.kde.org/r/112095/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112095/diff/1/?file=179718#file179718line119" \
style="color: black; font-weight: bold; text-decoration: \
underline;">server/lib/db/ratings.js</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">119</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kd">var</span> <span class="nx">ratingsQuery</span> <span class="o">=</span> \
<span class="s1">'SELECT attribute, rating FROM assetratings WHERE ASSET = $1 AND \
person = $2;'</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ASSET is \
not an SQL keyword; should therefore be lowercase</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112095/diff/1/?file=179718#file179718line121" \
style="color: black; font-weight: bold; text-decoration: \
underline;">server/lib/db/ratings.js</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">121</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kd">var</span> <span class="nx">json</span> <span class="o">=</span> <span \
class="nx">utils</span><span class="p">.</span><span \
class="nx">standardJson</span><span class="p">(</span><span \
class="nx">req</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this should \
be moved to line 137 (it's unused in the case of an error, so don't spend CPU \
cycles creating it)</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112095/diff/1/?file=179718#file179718line123" \
style="color: black; font-weight: bold; text-decoration: \
underline;">server/lib/db/ratings.js</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">123</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kd">var</span> <span class="nx">assetId</span> <span class="o">=</span> <span \
class="nx">req</span><span class="p">.</span><span class="nx">params</span><span \
class="p">.</span><span class="nx">assetId</span><span class="p">;</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should be \
using utils.parseNumber and checking for > 0 in the if statement below</pre> \
</div> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112095/diff/1/?file=179719#file179719line365" \
style="color: black; font-weight: bold; text-decoration: \
underline;">server/routes.js</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">function serverPath(path)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">365</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nx">app</span><span class="p">.</span><span class="nx">get</span><span \
class="p">(</span><span class="nx">serverPath</span><span class="p">(</span><span \
class="s1">'asset/participant/ratings/:assetId'</span><span \
class="p">),</span> <span class="nx">isAuthorized</span><span \
class="p">,</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this should \
be merged with asset/participant/ratings above as:
'asset/participant/ratings/:assetId?'
this makes it consistent with other similar routes that optionally take a asset or \
other id that narrows the result set down.
see the 'collection/list/:collectionId?' route for a pattern to follow</pre>
</div>
<br />
<p>- Aaron J.</p>
<br />
<p>On August 15th, 2013, 7:11 a.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Aug. 15, 2013, 7:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds the route asset/participant/ratings/:assetId which gives \
us the user's ratings for a specific asset.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">the tests are passing </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>server/doc/bodega.json <span style="color: grey">(3efd1cf)</span></li>
<li>server/lib/bodegadb.js <span style="color: grey">(20a8ef8)</span></li>
<li>server/lib/db/ratings.js <span style="color: grey">(e5f4bed)</span></li>
<li>server/routes.js <span style="color: grey">(903c9a3)</span></li>
<li>server/test/ratings.js <span style="color: grey">(8538e86)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112095/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic