'Re: Review Request 111797: populate the assetinfo with ratings'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-active
Subject:    Re: Review Request 111797: populate the assetinfo with ratings
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2013-07-30 16:33:00
Message-ID: 20130730163300.15316.83137 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111797/#review36824
-----------------------------------------------------------

Ship it!

Ship It!

- Aaron J. Seigo

On July 30, 2013, 4:23 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111797/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 4:23 p.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Description
> -------
> 
> This patch populates the asset/:assetId with the # of ratings and the average rating.
> Docs and tests are also being included. 
> 
> 
> Diffs
> -----
> 
>   server/doc/bodega.json f973bda 
>   server/lib/db/assetinfo.js 9e3755d 
>   server/test/assetinfo.js e46387a 
>   sql/ratings.sql 841045f 
> 
> Diff: http://git.reviewboard.kde.org/r/111797/diff/
> 
> 
> Testing
> -------
> 
> my test passes
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111797/">http://git.reviewboard.kde.org/r/111797/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Aaron J.</p>

<br />
<p>On July 30th, 2013, 4:23 p.m. UTC, Giorgos Tsiapaliokas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated July 30, 2013, 4:23 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch populates the asset/:assetId with the # of ratings and the \
average rating. Docs and tests are also being included. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">my test passes</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>server/doc/bodega.json <span style="color: grey">(f973bda)</span></li>

 <li>server/lib/db/assetinfo.js <span style="color: grey">(9e3755d)</span></li>

 <li>server/test/assetinfo.js <span style="color: grey">(e46387a)</span></li>

 <li>sql/ratings.sql <span style="color: grey">(841045f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111797/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

[prev in list] [next in list] [prev in thread] [next in thread] 