[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-active
Subject: Re: Review Request 111654: add support for the discourse
From: "Giorgos Tsiapaliokas" <terietor () gmail ! com>
Date: 2013-07-27 7:02:27
Message-ID: 20130727070227.23783.18490 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On July 23, 2013, 1:02 p.m., Aaron J. Seigo wrote:
> > why a clone of the discourse repo on github? was this to ensure that changes that \
> > happen in upstream discourse do not cause unexpected problems? or do you have \
> > actual changes in your github clone?
> > the installation procedure needs to be recorded in the README, but i suppose i \
> > can do that once this is in.
> > one this patch is in, there will need to modifications made to the asset info API \
> > in bodega-server to include a link to the discussion forum. that implies adding a \
> > new service block to the config.json for things like the url to the discourse \
> > server.
>
> Giorgos Tsiapaliokas wrote:
> > why a clone of the discourse repo on github?
>
> The repository is in github because at the time that I created I wasn't sure
> if we will need it and then I just continued to use it. If github isn't good
> for us I can move it to projects.kde.org.
>
> > was this to ensure that changes that happen in upstream discourse do not cause \
> > unexpected problems? or do you have actual changes in your github clone?
>
> yes to both of them.
>
> The changes to my github clone are related to our encryption. Discourse wasn't
> using bcrypt and since we are syncing the password hashes there was no other way in \
> order to make it possible for the users to log in.
>
> Aaron J. Seigo wrote:
> Ah, right, BCrypt. What does discourse use by default? I wonder if we could \
> convince them (e.g. by a patch) to make that configurable. Hummmmm...
By default they are using Pbkdf2.
Yes we could send them a patch, the config files are already \
there(discourse/config/database.yml.production-sample).
- Giorgos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111654/#review36379
-----------------------------------------------------------
On July 23, 2013, 10:20 a.m., Giorgos Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111654/
> -----------------------------------------------------------
>
> (Updated July 23, 2013, 10:20 a.m.)
>
>
> Review request for Bodega.
>
>
> Description
> -------
>
> This patch keeps in sync the DBs of the bodega-server and discourse.
>
> It syncs,
>
> a. the user accounts*
> b. for each asset that has a partner with id > 1000 it create a new forum which has \
> a topic and a post
> * there is a default account for the discourse
> username: forumadmin
> password: password
>
>
> Diffs
> -----
>
> server/bodegaDbHelper 273e34f
> sql/discourse.plsql PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/111654/diff/
>
>
> Testing
> -------
>
> How to test it,
>
> * git clone https://github.com/terietor/discourse.git
> * cd discourse
> * git checkout bodega
> * https://github.com/terietor/discourse/blob/master/docs/DEVELOPER-ADVANCED.md
> * cd bodega-server/server
> * make sql && make test-sql (your bodega user must be a superuser in order to \
> enable the dblink extention)
> * then go back to discourse and do `bundle exec rails s`
> * go to localhost:3000
>
>
> Thanks,
>
> Giorgos Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111654/">http://git.reviewboard.kde.org/r/111654/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 23rd, 2013, 1:02 p.m. UTC, <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">why a clone of the discourse repo on github? was this to ensure that \
changes that happen in upstream discourse do not cause unexpected problems? or do you \
have actual changes in your github clone?
the installation procedure needs to be recorded in the README, but i suppose i can do \
that once this is in.
one this patch is in, there will need to modifications made to the asset info API in \
bodega-server to include a link to the discussion forum. that implies adding a new \
service block to the config.json for things like the url to the discourse server. \
</pre> </blockquote>
<p>On July 26th, 2013, 6:34 p.m. UTC, <b>Giorgos Tsiapaliokas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>why a clone of the \
discourse repo on github?
The repository is in github because at the time that I created I wasn't sure
if we will need it and then I just continued to use it. If github isn't good
for us I can move it to projects.kde.org.
>was this to ensure that changes that happen in upstream discourse do not cause \
unexpected problems? >or do you have actual changes in your github clone?
yes to both of them.
The changes to my github clone are related to our encryption. Discourse wasn't
using bcrypt and since we are syncing the password hashes there was no other way in \
order to make it possible for the users to log in.</pre>
</blockquote>
<p>On July 26th, 2013, 9:55 p.m. UTC, <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, right, BCrypt. What \
does discourse use by default? I wonder if we could convince them (e.g. by a patch) \
to make that configurable. Hummmmm...</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">By default they are \
using Pbkdf2.
Yes we could send them a patch, the config files are already \
there(discourse/config/database.yml.production-sample). </pre>
<br />
<p>- Giorgos</p>
<br />
<p>On July 23rd, 2013, 10:20 a.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated July 23, 2013, 10:20 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch keeps in sync the DBs of the bodega-server and discourse.
It syncs,
a. the user accounts*
b. for each asset that has a partner with id > 1000 it create a new forum which \
has a topic and a post
* there is a default account for the discourse
username: forumadmin
password: password</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">How to test it,
* git clone https://github.com/terietor/discourse.git
* cd discourse
* git checkout bodega
* https://github.com/terietor/discourse/blob/master/docs/DEVELOPER-ADVANCED.md
* cd bodega-server/server
* make sql && make test-sql (your bodega user must be a superuser in order to \
enable the dblink extention)
* then go back to discourse and do `bundle exec rails s`
* go to localhost:3000</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>server/bodegaDbHelper <span style="color: grey">(273e34f)</span></li>
<li>sql/discourse.plsql <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111654/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic