From kde-active Fri Jul 26 12:13:28 2013 From: "Commit Hook" Date: Fri, 26 Jul 2013 12:13:28 +0000 To: kde-active Subject: Re: Review Request 111401: implement ratings in the bodega-server Message-Id: <20130726121328.29219.66855 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-active&m=137484083129788 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6718880380980402930==" --===============6718880380980402930== Content-Type: multipart/alternative; boundary="===============6775594867333910224==" --===============6775594867333910224== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111401/ ----------------------------------------------------------- (Updated July 26, 2013, 12:13 p.m.) Status ------ This change has been marked as submitted. Review request for Bodega. Description ------- This patch implements the ratings feature in the bodega-server. I have also attached a screenshot of the apidocs. Diffs ----- server/bodegaDbHelper ba740cb server/doc/bodega.json 59c14e3 server/lib/bodegadb.js 3be8d81 server/lib/db/ratings.js PRE-CREATION server/lib/errors.js 356d7c4 server/routes.js 726fc80 server/test/ratings.js PRE-CREATION server/test/support/http.js 84a5fee sql/core.plsql 7b92784 sql/ratings.sql PRE-CREATION sql/testdata.sql dd15d57 Diff: http://git.reviewboard.kde.org/r/111401/diff/ Testing ------- ./node_modules/.bin/mocha test/ratings.js --reporter spec WARNING: Setting up server with no ssl! Bodega server listening on localhost:3000 in devel mode Ratings needs to authorize first ? authorize correctly. (107ms) List Attributes ? it should fail because the asset is invalid ? it should succeed Remove asset rate ? it should fail because the asset is invalid ? it should succeed Asset Ratings ? it should fail because the asset is invalid ? it should succeed ? it should be empty because there are no ratings for the asset Participant ? it should succeed ? it should have no ratings Add asset rate ? it should fail because the asset is invalid ? it should succeed 12 passing (219 ms) File Attachments ---------------- http://git.reviewboard.kde.org/media/uploaded/files/2013/07/05/bodega-ratings-apidocs.png Thanks, Giorgos Tsiapaliokas --===============6775594867333910224== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111401/

This change has been marked as submitted.

Review request for Bodega.

By Giorgos Tsiapaliokas.

Updated July 26, 2013, 12:13 p.m.

Description

This patch implements the ratings feature in the bodega-server.

I have also attached a screenshot of the apidocs.

Testing

./node_modules/.bin/mocha test/ratings.js --reporter spec
WARNING: Setting up server with no ssl!
Bodega server listening on localhost:3000 in devel mode


  Ratings
    needs to authorize first
      ? authorize correctly. (107ms)
    List Attributes
      ? it should fail because the asset is invalid 
      ? it should succeed 
    Remove asset rate
      ? it should fail because the asset is invalid 
      ? it should succeed 
    Asset Ratings
      ? it should fail because the asset is invalid 
      ? it should succeed 
      ? it should be empty because there are no ratings for the asset 
    Participant
      ? it should succeed 
      ? it should have no ratings 
    Add asset rate
      ? it should fail because the asset is invalid 
      ? it should succeed 


  12 passing (219 ms)

Diffs

server/bodegaDbHelper (ba740cb)
server/doc/bodega.json (59c14e3)
server/lib/bodegadb.js (3be8d81)
server/lib/db/ratings.js (PRE-CREATION)
server/lib/errors.js (356d7c4)
server/routes.js (726fc80)
server/test/ratings.js (PRE-CREATION)
server/test/support/http.js (84a5fee)
sql/core.plsql (7b92784)
sql/ratings.sql (PRE-CREATION)
sql/testdata.sql (dd15d57)

File Attachments

bodega-ratings-apidocs.png

--===============6775594867333910224==-- --===============6718880380980402930== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Active mailing list Active@kde.org https://mail.kde.org/mailman/listinfo/active --===============6718880380980402930==--