'Re: Review Request 111162: Bodega-server: Add a test for puchasing an asset'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-active
Subject:    Re: Review Request 111162: Bodega-server: Add a test for puchasing an asset
From:       "Commit Hook" <null () kde ! org>
Date:       2013-07-26 9:26:18
Message-ID: 20130726092618.4086.77634 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111162/#review36527
-----------------------------------------------------------

This review has been submitted with commit 5e8b9db7ecb5cd95cb1d61350444fb4230323852 \
by Antonis Tsiapaliokas to branch master.

- Commit Hook

On July 26, 2013, 9:25 a.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111162/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 9:25 a.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Description
> -------
> 
> The test should check for the following:
> 
> * purchasing an asset the account does not have enough points for
> * purchase an asset the account does have enough points for
> * downloading the asset that was purchased
> * downloading an asset that costs points that was not purchased
> * downloading a free asset
> 
> Things that are missing:
> 
> * confirm points are properly distributed between store and asset owners
> * confirm download records are correct
> 
> 
> How can we verify the two above which are missing from the test?
> 
> 
> This addresses bug 320545.
> http://bugs.kde.org/show_bug.cgi?id=320545
> 
> 
> Diffs
> -----
> 
> server/lib/db/purchaseAsset.js 2613615 
> server/test/purchase.js PRE-CREATION 
> server/test/support/utils.js f4d5313 
> 
> Diff: http://git.reviewboard.kde.org/r/111162/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111162/">http://git.reviewboard.kde.org/r/111162/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 5e8b9db7ecb5cd95cb1d61350444fb4230323852 by Antonis \
Tsiapaliokas to branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On July 26th, 2013, 9:25 a.m. UTC, Antonis Tsiapaliokas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Bodega.</div>
<div>By Antonis Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated July 26, 2013, 9:25 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The test should check for the following:  
* purchasing an asset the account does not have enough points for
* purchase an asset the account does have enough points for
* downloading the asset that was purchased
* downloading an asset that costs points that was not purchased
* downloading a free asset

Things that are missing:

* confirm points are properly distributed between store and asset owners
* confirm download records are correct

How can we verify the two above which are missing from the test?
</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=320545">320545</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>server/lib/db/purchaseAsset.js <span style="color: grey">(2613615)</span></li>

 <li>server/test/purchase.js <span style="color: grey">(PRE-CREATION)</span></li>

 <li>server/test/support/utils.js <span style="color: grey">(f4d5313)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111162/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

[prev in list] [next in list] [prev in thread] [next in thread] 