'Re: Review Request 111401: implement ratings in the bodega-server'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-active
Subject:    Re: Review Request 111401: implement ratings in the bodega-server
From:       "Giorgos Tsiapaliokas" <terietor () gmail ! com>
Date:       2013-07-25 7:54:45
Message-ID: 20130725075445.14056.7528 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111401/
-----------------------------------------------------------

(Updated July 25, 2013, 7:54 a.m.)

Review request for Bodega.

Changes
-------

fix the issues

Description
-------

This patch implements the ratings feature in the bodega-server.

I have also attached a screenshot of the apidocs.

Diffs (updated)
-----

  server/bodegaDbHelper ba740cb 
  server/doc/bodega.json 59c14e3 
  server/lib/bodegadb.js 3be8d81 
  server/lib/db/ratings.js PRE-CREATION 
  server/lib/errors.js 356d7c4 
  server/routes.js 726fc80 
  server/test/ratings.js PRE-CREATION 
  server/test/support/http.js 84a5fee 
  sql/core.plsql 7b92784 
  sql/ratings.sql PRE-CREATION 
  sql/testdata.sql dd15d57 

Diff: http://git.reviewboard.kde.org/r/111401/diff/

Testing
-------

./node_modules/.bin/mocha test/ratings.js --reporter spec
WARNING: Setting up server with no ssl!
Bodega server listening on localhost:3000 in devel mode

  Ratings
    needs to authorize first
      ? authorize correctly. (107ms)
    List Attributes
      ? it should fail because the asset is invalid 
      ? it should succeed 
    Remove asset rate
      ? it should fail because the asset is invalid 
      ? it should succeed 
    Asset Ratings
      ? it should fail because the asset is invalid 
      ? it should succeed 
      ? it should be empty because there are no ratings for the asset 
    Participant
      ? it should succeed 
      ? it should have no ratings 
    Add asset rate
      ? it should fail because the asset is invalid 
      ? it should succeed 

  12 passing (219 ms)

File Attachments
----------------

  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/05/bodega-ratings-apidocs.png

Thanks,

Giorgos Tsiapaliokas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111401/">http://git.reviewboard.kde.org/r/111401/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated July 25, 2013, 7:54 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">fix the issues</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch implements the ratings feature in the bodega-server.

I have also attached a screenshot of the apidocs.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">./node_modules/.bin/mocha test/ratings.js --reporter \
                spec
WARNING: Setting up server with no ssl!
Bodega server listening on localhost:3000 in devel mode

  Ratings
    needs to authorize first
      ? authorize correctly. (107ms)
    List Attributes
      ? it should fail because the asset is invalid 
      ? it should succeed 
    Remove asset rate
      ? it should fail because the asset is invalid 
      ? it should succeed 
    Asset Ratings
      ? it should fail because the asset is invalid 
      ? it should succeed 
      ? it should be empty because there are no ratings for the asset 
    Participant
      ? it should succeed 
      ? it should have no ratings 
    Add asset rate
      ? it should fail because the asset is invalid 
      ? it should succeed 

  12 passing (219 ms)
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>server/bodegaDbHelper <span style="color: grey">(ba740cb)</span></li>

 <li>server/doc/bodega.json <span style="color: grey">(59c14e3)</span></li>

 <li>server/lib/bodegadb.js <span style="color: grey">(3be8d81)</span></li>

 <li>server/lib/db/ratings.js <span style="color: grey">(PRE-CREATION)</span></li>

 <li>server/lib/errors.js <span style="color: grey">(356d7c4)</span></li>

 <li>server/routes.js <span style="color: grey">(726fc80)</span></li>

 <li>server/test/ratings.js <span style="color: grey">(PRE-CREATION)</span></li>

 <li>server/test/support/http.js <span style="color: grey">(84a5fee)</span></li>

 <li>sql/core.plsql <span style="color: grey">(7b92784)</span></li>

 <li>sql/ratings.sql <span style="color: grey">(PRE-CREATION)</span></li>

 <li>sql/testdata.sql <span style="color: grey">(dd15d57)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111401/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/07/05/bodega-ratings-apidocs.png">bodega-ratings-apidocs.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

[prev in list] [next in list] [prev in thread] [next in thread] 