[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-active
Subject: Re: Review Request 111369: add support for the collection in the active-addons
From: "Commit Hook" <null () kde ! org>
Date: 2013-07-16 15:56:32
Message-ID: 20130716155632.24451.47573 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111369/
-----------------------------------------------------------
(Updated July 16, 2013, 3:56 p.m.)
Status
------
This change has been marked as submitted.
Review request for Bodega.
Description
-------
This patch adds support for the collections in the active-addons.
Diffs
-----
activeclient/package/contents/ui/storebrowser/ItemBrowser.qml 1ba83bf
activeclient/package/contents/ui/storebrowser/ListCollectionAssetsJobColumn.qml PRE-CREATION
activeclient/package/contents/ui/storebrowser/ListCollectionsJobColumn.qml PRE-CREATION
activeclient/package/contents/ui/storebrowser/OverviewColumn.qml 8befff5
activeclient/src/bodegastore.h a305d11
activeclient/src/bodegastore.cpp 78ded47
lib/CMakeLists.txt 381c03f
lib/bodega/CMakeLists.txt 1ecc498
lib/bodega/ballotaddassetjob.h 2447a46
lib/bodega/ballotaddassetjob.cpp 1fb425b
lib/bodega/ballotlistassetsjob.h 41e42cd
lib/bodega/ballotlistassetsjob.cpp 9492f25
lib/bodega/ballotremoveassetjob.h 7e6f2d3
lib/bodega/ballotremoveassetjob.cpp f50c112
lib/bodega/collectionaddassetjob.h PRE-CREATION
lib/bodega/collectionaddassetjob.cpp PRE-CREATION
lib/bodega/collectionlistassetsjob.h PRE-CREATION
lib/bodega/collectionlistassetsjob.cpp PRE-CREATION
lib/bodega/collectionlistassetsjobmodel.h PRE-CREATION
lib/bodega/collectionlistassetsjobmodel.cpp PRE-CREATION
lib/bodega/collectionremoveassetjob.h PRE-CREATION
lib/bodega/collectionremoveassetjob.cpp PRE-CREATION
lib/bodega/createballotjob.h d6f4de3
lib/bodega/createballotjob.cpp 01e2926
lib/bodega/createcollectionjob.h PRE-CREATION
lib/bodega/createcollectionjob.cpp PRE-CREATION
lib/bodega/deleteballotjob.h d6c53d2
lib/bodega/deleteballotjob.cpp d7cec5e
lib/bodega/deletecollectionjob.h PRE-CREATION
lib/bodega/deletecollectionjob.cpp PRE-CREATION
lib/bodega/globals.h 84fe9b8
lib/bodega/listballotsjob.h 30fc24b
lib/bodega/listballotsjob.cpp 00bf45c
lib/bodega/listcollectionsjob.h PRE-CREATION
lib/bodega/listcollectionsjob.cpp PRE-CREATION
lib/bodega/listcollectionsjobmodel.h PRE-CREATION
lib/bodega/listcollectionsjobmodel.cpp PRE-CREATION
lib/bodega/session.h 6491029
lib/bodega/session.cpp 6998da8
Diff: http://git.reviewboard.kde.org/r/111369/diff/
Testing
-------
I have tested the active-addons with the testdata
File Attachments
----------------
http://git.reviewboard.kde.org/media/uploaded/files/2013/07/02/bodega-collection-native.png
Thanks,
Giorgos Tsiapaliokas
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111369/">http://git.reviewboard.kde.org/r/111369/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated July 16, 2013, 3:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds support for the collections in the active-addons.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have tested the active-addons with the testdata</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>activeclient/package/contents/ui/storebrowser/ItemBrowser.qml <span \
style="color: grey">(1ba83bf)</span></li>
<li>activeclient/package/contents/ui/storebrowser/ListCollectionAssetsJobColumn.qml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>activeclient/package/contents/ui/storebrowser/ListCollectionsJobColumn.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>activeclient/package/contents/ui/storebrowser/OverviewColumn.qml <span \
style="color: grey">(8befff5)</span></li>
<li>activeclient/src/bodegastore.h <span style="color: grey">(a305d11)</span></li>
<li>activeclient/src/bodegastore.cpp <span style="color: grey">(78ded47)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(381c03f)</span></li>
<li>lib/bodega/CMakeLists.txt <span style="color: grey">(1ecc498)</span></li>
<li>lib/bodega/ballotaddassetjob.h <span style="color: grey">(2447a46)</span></li>
<li>lib/bodega/ballotaddassetjob.cpp <span style="color: grey">(1fb425b)</span></li>
<li>lib/bodega/ballotlistassetsjob.h <span style="color: grey">(41e42cd)</span></li>
<li>lib/bodega/ballotlistassetsjob.cpp <span style="color: \
grey">(9492f25)</span></li>
<li>lib/bodega/ballotremoveassetjob.h <span style="color: \
grey">(7e6f2d3)</span></li>
<li>lib/bodega/ballotremoveassetjob.cpp <span style="color: \
grey">(f50c112)</span></li>
<li>lib/bodega/collectionaddassetjob.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/collectionaddassetjob.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/collectionlistassetsjob.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/collectionlistassetsjob.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/collectionlistassetsjobmodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/collectionlistassetsjobmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/collectionremoveassetjob.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/collectionremoveassetjob.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/createballotjob.h <span style="color: grey">(d6f4de3)</span></li>
<li>lib/bodega/createballotjob.cpp <span style="color: grey">(01e2926)</span></li>
<li>lib/bodega/createcollectionjob.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/createcollectionjob.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/deleteballotjob.h <span style="color: grey">(d6c53d2)</span></li>
<li>lib/bodega/deleteballotjob.cpp <span style="color: grey">(d7cec5e)</span></li>
<li>lib/bodega/deletecollectionjob.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/deletecollectionjob.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/globals.h <span style="color: grey">(84fe9b8)</span></li>
<li>lib/bodega/listballotsjob.h <span style="color: grey">(30fc24b)</span></li>
<li>lib/bodega/listballotsjob.cpp <span style="color: grey">(00bf45c)</span></li>
<li>lib/bodega/listcollectionsjob.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/listcollectionsjob.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/listcollectionsjobmodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/listcollectionsjobmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/bodega/session.h <span style="color: grey">(6491029)</span></li>
<li>lib/bodega/session.cpp <span style="color: grey">(6998da8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111369/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/07/02/bodega-collection-native.png">bodega-collection-native.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic