--===============9134274869621235331== Content-Type: multipart/alternative; boundary="===============8675116252754310559==" --===============8675116252754310559== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111162/#review34840 ----------------------------------------------------------- these two points: * confirm points are properly distributed between store and asset owners * confirm download records are correct will have to be done with raw sql. see the after function in store.sql for an example of how to run sql from tests directly against the database. queries can be done to pull the relevant information and test against it. server/test/purchase.js this should be made part of the `make test_data` run.. it should both process the testdata.sql file as well as copy over sets of test data into the appropriate location. - Aaron J. Seigo On June 21, 2013, 2:02 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111162/ > ----------------------------------------------------------- > > (Updated June 21, 2013, 2:02 p.m.) > > > Review request for Bodega. > > > Description > ------- > > The test should check for the following: > > * purchasing an asset the account does not have enough points for > * purchase an asset the account does have enough points for > * downloading the asset that was purchased > * downloading an asset that costs points that was not purchased > * downloading a free asset > > Things that are missing: > > * confirm points are properly distributed between store and asset owners > * confirm download records are correct > > > How can we verify the two above which are missing from the test? > > > This addresses bug 320545. > http://bugs.kde.org/show_bug.cgi?id=320545 > > > Diffs > ----- > > server/lib/db/purchaseAsset.js 2613615 > server/test/purchase.js PRE-CREATION > server/test/support/http.js 84a5fee > sql/testdata.sql d151c17 > > Diff: http://git.reviewboard.kde.org/r/111162/diff/ > > > Testing > ------- > > > Thanks, > > Antonis Tsiapaliokas > > --===============8675116252754310559== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111162/

these two points:

* confirm points are properly distributed between store and asset owners
* confirm download records are correct

will have to be done with raw sql. see the after function in store.sql for an example of how to run sql from tests directly against the database. queries can be done to pull the relevant information and test against it.

server/test/purchase.js (Diff revision 1)
		113	it('should create an empty file first', function(done) {
		114	fs.openSync(folderPath + 'org.kde.poker1.plasmoid', 'w');
		115	done();

this should be made part of the `make test_data` run.. it should both process the testdata.sql file as well as copy over sets of test data into the appropriate location.

- Aaron J.

On June 21st, 2013, 2:02 p.m. UTC, Antonis Tsiapaliokas wrote:

Review request for Bodega.

By Antonis Tsiapaliokas.

Updated June 21, 2013, 2:02 p.m.

Description

The test should check for the following:
    
* purchasing an asset the account does not have enough points for
* purchase an asset the account does have enough points for
* downloading the asset that was purchased
* downloading an asset that costs points that was not purchased
* downloading a free asset

Things that are missing:

* confirm points are properly distributed between store and asset owners
* confirm download records are correct


How can we verify the two above which are missing from the test?

Bugs: 320545

Diffs

server/lib/db/purchaseAsset.js (2613615)
server/test/purchase.js (PRE-CREATION)
server/test/support/http.js (84a5fee)
sql/testdata.sql (d151c17)

--===============8675116252754310559==-- --===============9134274869621235331== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Active mailing list Active@kde.org https://mail.kde.org/mailman/listinfo/active --===============9134274869621235331==--