'Re: Review Request 110627: fix regression from commit 295d707e9deb15a3643c3e77a504336f50823956'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-active
Subject:    Re: Review Request 110627: fix regression from commit 295d707e9deb15a3643c3e77a504336f50823956
From:       "Commit Hook" <null () kde ! org>
Date:       2013-05-24 15:44:34
Message-ID: 20130524154434.25339.20928 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110627/#review33096
-----------------------------------------------------------

This review has been submitted with commit e1b800102768e0e733412928b7612924e57e2a97 \
by Aaron Seigo on behalf of Giorgos Tsiapaliokas to branch integration.

- Commit Hook

On May 24, 2013, 3:26 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110627/
> -----------------------------------------------------------
> 
> (Updated May 24, 2013, 3:26 p.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Description
> -------
> 
> Hello,
> 
> this patch fixes the regression from the commit \
> 295d707e9deb15a3643c3e77a504336f50823956 . The \
> 295d707e9deb15a3643c3e77a504336f50823956 made the server unable to send \
> confirmation emails. 
> 
> Diffs
> -----
> 
> server/lib/db/register.js 9a63086 
> server/lib/utils.js 1adcf9a 
> 
> Diff: http://git.reviewboard.kde.org/r/110627/diff/
> 
> 
> Testing
> -------
> 
> I have attached a screenshot in which I received an email during
> the registration.
> 
> For a mail server I used my gmail account and I started the
> server with 'node app.js'.
> 
> 
> File Attachments
> ----------------
> 
> 
> http://git.reviewboard.kde.org/media/uploaded/files/2013/05/24/confirmMail.png
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110627/">http://git.reviewboard.kde.org/r/110627/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit e1b800102768e0e733412928b7612924e57e2a97 by Aaron Seigo on \
behalf of Giorgos Tsiapaliokas to branch integration.</pre>  <br />

<p>- Commit</p>

<br />
<p>On May 24th, 2013, 3:26 p.m. UTC, Giorgos Tsiapaliokas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated May 24, 2013, 3:26 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,

this patch fixes the regression from the commit \
295d707e9deb15a3643c3e77a504336f50823956 . The \
295d707e9deb15a3643c3e77a504336f50823956 made the server unable to send confirmation \
emails.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have attached a screenshot in which I received an email during the \
registration.

For a mail server I used my gmail account and I started the
server with &#39;node app.js&#39;.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>server/lib/db/register.js <span style="color: grey">(9a63086)</span></li>

 <li>server/lib/utils.js <span style="color: grey">(1adcf9a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110627/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/24/confirmMail.png">confirmMail.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

[prev in list] [next in list] [prev in thread] [next in thread] 