'Re: Review Request 110103: add support for account deactivation'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-active
Subject:    Re: Review Request 110103: add support for account deactivation
From:       "Commit Hook" <null () kde ! org>
Date:       2013-05-12 21:04:01
Message-ID: 20130512210401.22211.52084 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110103/#review32406
-----------------------------------------------------------

This review has been submitted with commit d1857350bba9998310c00833dbc08067032e22ca \
by Giorgos Tsiapaliokas to branch terietor/account/activation2.

- Commit Hook

On April 21, 2013, 10:03 a.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110103/
> -----------------------------------------------------------
> 
> (Updated April 21, 2013, 10:03 a.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Description
> -------
> 
> This patch adds support for account [de]activation.
> 
> P.S.: Actually this patch contains 2 commits. The
> first one allows to use comments in the config.sample.json file.
> It was an overkill to open a second review
> 
> 
> This addresses bug 318251.
> http://bugs.kde.org/show_bug.cgi?id=318251
> 
> 
> Diffs
> -----
> 
> server/config.sample.json 20a3161 
> server/lib/db/changeAccountDetails.js 3db32fb 
> server/lib/db/participantInfo.js 37817d4 
> 
> Diff: http://git.reviewboard.kde.org/r/110103/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110103/">http://git.reviewboard.kde.org/r/110103/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit d1857350bba9998310c00833dbc08067032e22ca by Giorgos \
Tsiapaliokas to branch terietor/account/activation2.</pre>  <br />

<p>- Commit</p>

<br />
<p>On April 21st, 2013, 10:03 a.m. UTC, Giorgos Tsiapaliokas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated April 21, 2013, 10:03 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds support for account [de]activation.

P.S.: Actually this patch contains 2 commits. The
first one allows to use comments in the config.sample.json file.
It was an overkill to open a second review</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=318251">318251</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>server/config.sample.json <span style="color: grey">(20a3161)</span></li>

 <li>server/lib/db/changeAccountDetails.js <span style="color: \
grey">(3db32fb)</span></li>

 <li>server/lib/db/participantInfo.js <span style="color: grey">(37817d4)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110103/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

[prev in list] [next in list] [prev in thread] [next in thread] 