'Re: Review Request 109975: various fixes to sql scripts and package.json'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-active
Subject:    Re: Review Request 109975: various fixes to sql scripts and package.json
From:       "Giorgos Tsiapaliokas" <terietor () gmail ! com>
Date:       2013-04-23 15:45:48
Message-ID: 20130423154548.18288.34213 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On April 20, 2013, 1:37 p.m., Commit Hook wrote:
> > This review has been submitted with commit \
> > 7b5b517ff25d01a801b6a1a688aaffd61307acaf by Giorgos Tsiapaliokas to branch \
> > master.
> 
> Aleix Pol Gonzalez wrote:
> > ) cool! good work!!

> )

- Giorgos

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109975/#review31329
-----------------------------------------------------------

On April 20, 2013, 1:37 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109975/
> -----------------------------------------------------------
> 
> (Updated April 20, 2013, 1:37 p.m.)
> 
> 
> Review request for Bodega.
> 
> 
> Description
> -------
> 
> This patch does,
> 
> * adds a sql/updates dir
> * impoves the setup.sh file
> * executes the sql/updates scripts before npm updates
> * populates the package.json
> ** adds a restriction to node
> ** overrides the default functionality of npm start
> 
> 
> Diffs
> -----
> 
> README 7515b65 
> server/config.json PRE-CREATION 
> server/config.sample.json 16de381 
> server/package.json e68c27c 
> sql/do_sql PRE-CREATION 
> sql/setup.sh 82cf22e 
> sql/updates/README PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109975/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109975/">http://git.reviewboard.kde.org/r/109975/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On April 20th, 2013, 1:37 p.m. UTC, <b>Commit \
Hook</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This review has been submitted with commit \
7b5b517ff25d01a801b6a1a688aaffd61307acaf by Giorgos Tsiapaliokas to branch \
master.</pre>  </blockquote>

 <p>On April 22nd, 2013, 1:02 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">:) cool! good \
work!!</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">:)</pre> <br />

<p>- Giorgos</p>

<br />
<p>On April 20th, 2013, 1:37 p.m. UTC, Giorgos Tsiapaliokas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated April 20, 2013, 1:37 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch does,

    * adds a sql/updates dir
    * impoves the setup.sh file
    * executes the sql/updates scripts before npm updates
    * populates the package.json
    ** adds a restriction to node
    ** overrides the default functionality of npm start</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>README <span style="color: grey">(7515b65)</span></li>

 <li>server/config.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>server/config.sample.json <span style="color: grey">(16de381)</span></li>

 <li>server/package.json <span style="color: grey">(e68c27c)</span></li>

 <li>sql/do_sql <span style="color: grey">(PRE-CREATION)</span></li>

 <li>sql/setup.sh <span style="color: grey">(82cf22e)</span></li>

 <li>sql/updates/README <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109975/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active

[prev in list] [next in list] [prev in thread] [next in thread] 