[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-active
Subject: Re: Review Request 109975: various fixes to sql scripts and package.json
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2013-04-12 18:16:46
Message-ID: 20130412181646.11364.99636 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 12, 2013, 5:19 p.m., Aleix Pol Gonzalez wrote:
> > sql/setup.sh, line 6
> > <http://git.reviewboard.kde.org/r/109975/diff/1/?file=138353#file138353line6>
> >
> > Shouldn't these come from the config.json file?
that would be nice, but it's not parsed/sourced by this script. it would mean either \
bringing in a json parser to this, or writing this in js. the latter wouldn't be the \
worst idea in the world, really.
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109975/#review30962
-----------------------------------------------------------
On April 12, 2013, 2:40 p.m., Giorgos Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109975/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 2:40 p.m.)
>
>
> Review request for Bodega.
>
>
> Description
> -------
>
> This patch does,
>
> * adds a sql/updates dir
> * impoves the setup.sh file
> * executes the sql/updates scripts before npm updates
> * populates the package.json
> ** adds a restriction to node
> ** overrides the default functionality of npm start
>
>
> Diffs
> -----
>
> README 7515b65
> server/package.json e68c27c
> sql/setup.sh 82cf22e
> sql/updates/README PRE-CREATION
> sql/updates/do_updates.sh PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/109975/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Giorgos Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109975/">http://git.reviewboard.kde.org/r/109975/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 12th, 2013, 5:19 p.m. UTC, <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109975/diff/1/?file=138353#file138353line6" \
style="color: black; font-weight: bold; text-decoration: underline;">sql/setup.sh</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">6</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">psql -d bodega -U bodega -f \
search_en.plsql 1>/dev/null</pre></td> <th bgcolor="#e9eaa8" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">6</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "><span class="nv">database</span><span \
class="o">=</span><span class="s2">"bodega"</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shouldn't these come \
from the config.json file?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">that would \
be nice, but it's not parsed/sourced by this script. it would mean either \
bringing in a json parser to this, or writing this in js. the latter wouldn't be \
the worst idea in the world, really.</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On April 12th, 2013, 2:40 p.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated April 12, 2013, 2:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch does,
* adds a sql/updates dir
* impoves the setup.sh file
* executes the sql/updates scripts before npm updates
* populates the package.json
** adds a restriction to node
** overrides the default functionality of npm start</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>README <span style="color: grey">(7515b65)</span></li>
<li>server/package.json <span style="color: grey">(e68c27c)</span></li>
<li>sql/setup.sh <span style="color: grey">(82cf22e)</span></li>
<li>sql/updates/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>sql/updates/do_updates.sh <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109975/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic