[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-active
Subject:    Re: [Nepomuk] porting stuff to Nepomuk2
From:       Vishesh Handa <me () vhanda ! in>
Date:       2012-07-18 8:14:16
Message-ID: CAOPTMKC+EwQHB3iYmaMbwuoPwwGxBS-4vaiNWE5ryG+6P1450A () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Thu, Jul 12, 2012 at 10:37 PM, Marco Martin <notmart@gmail.com> wrote:

> On Wednesday 11 July 2012, Vishesh Handa wrote:
> > > > uses nepomuk2_rcgen. Cause I don't think the packagers would like us
> > >
> > > having
> > >
> > > > 2 pacakges (nepomuk-core and kdelibs) install the same cmake file.
> > >
> > > i added it now in the nepomuk-core repo, same mart/rcgenNepomuk2 branch
> >
> > great.
> >
> > If you could just test it out a bit more, then we can merge it into
> master.
> >
>
> i ported the share-like-connect repo to nepomuk2 as well, so far so good
> (even
> tough will need setsymbols again)
>
> now only takes some volunteer porting something else that was using
> NepomukAddOntologyClasses to be really safe :p
>

Hey Marco

I decided to test out the rcgen2, and found some minor problems -

* Resource::resourceUri is now uri() - My fault. I made this change in
nepomuk-core. FIXED.
* Missing "resource.h" when trying to compile the generated classes.

Does it work for you?

This simple patch fixed it for me, but I'm not sure if I should commit it.

diff --git a/rcgen/codegenerator.cpp b/rcgen/codegenerator.cpp
index 8c5d9b5..e45c7b0 100644
--- a/rcgen/codegenerator.cpp
+++ b/rcgen/codegenerator.cpp
@@ -155,7 +155,7 @@ bool CodeGenerator::writeHeader( const ResourceClass
*resourceClass, QTextStream
         s.replace( "NEPOMUK_PARENT_INCLUDE", QString("\"%1.h\"").arg(
parent->name().toLower() ) );
     }
     else {
-        s.replace( "NEPOMUK_PARENT_INCLUDE", QString("\"resource.h\"") );
+        s.replace( "NEPOMUK_PARENT_INCLUDE",
QString("<Nepomuk2/Resource>") );
     }

     QString methods;



> Cheers,
> Marco Martin
> _______________________________________________
> Nepomuk mailing list
> Nepomuk@kde.org
> https://mail.kde.org/mailman/listinfo/nepomuk
>



-- 
Vishesh Handa

[Attachment #5 (text/html)]

<br><br><div class="gmail_quote">On Thu, Jul 12, 2012 at 10:37 PM, Marco Martin <span \
dir="ltr">&lt;<a href="mailto:notmart@gmail.com" \
target="_blank">notmart@gmail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <div class="im">On Wednesday 11 July 2012, Vishesh Handa \
wrote:<br> </div><div class="im">&gt; &gt; &gt; uses nepomuk2_rcgen. Cause I \
don&#39;t think the packagers would like us<br> &gt; &gt;<br>
&gt; &gt; having<br>
&gt; &gt;<br>
&gt; &gt; &gt; 2 pacakges (nepomuk-core and kdelibs) install the same cmake file.<br>
&gt; &gt;<br>
&gt; &gt; i added it now in the nepomuk-core repo, same mart/rcgenNepomuk2 branch<br>
&gt;<br>
&gt; great.<br>
&gt;<br>
&gt; If you could just test it out a bit more, then we can merge it into master.<br>
&gt;<br>
<br>
</div>i ported the share-like-connect repo to nepomuk2 as well, so far so good \
(even<br> tough will need setsymbols again)<br>
<br>
now only takes some volunteer porting something else that was using<br>
NepomukAddOntologyClasses to be really safe :p<br></blockquote><div><br>Hey \
Marco<br><br>I decided to test out the rcgen2, and found some minor problems \
-<br><br>* Resource::resourceUri is now uri() - My fault. I made this change in \
                nepomuk-core. FIXED.<br>
* Missing &quot;resource.h&quot; when trying to compile the generated \
classes.<br><br>Does it work for you?<br><br>This simple patch fixed it for me, but \
I&#39;m not sure if I should commit it.<br><br>diff --git a/rcgen/codegenerator.cpp \
b/rcgen/codegenerator.cpp<br> index 8c5d9b5..e45c7b0 100644<br>--- \
a/rcgen/codegenerator.cpp<br>+++ b/rcgen/codegenerator.cpp<br>@@ -155,7 +155,7 @@ \
bool CodeGenerator::writeHeader( const ResourceClass *resourceClass, QTextStream<br>  \
s.replace( &quot;NEPOMUK_PARENT_INCLUDE&quot;, \
QString(&quot;\&quot;%1.h\&quot;&quot;).arg( parent-&gt;name().toLower() ) );<br>  \
}<br>     else {<br>-        s.replace( &quot;NEPOMUK_PARENT_INCLUDE&quot;, \
QString(&quot;\&quot;resource.h\&quot;&quot;) );<br>+        s.replace( \
&quot;NEPOMUK_PARENT_INCLUDE&quot;, QString(&quot;&lt;Nepomuk2/Resource&gt;&quot;) \
);<br>  }<br> <br>     QString methods;<br> <br><br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"> <div class="HOEnZb"><div class="h5"><br>
Cheers,<br>
Marco Martin<br>
_______________________________________________<br>
Nepomuk mailing list<br>
<a href="mailto:Nepomuk@kde.org">Nepomuk@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/nepomuk" \
target="_blank">https://mail.kde.org/mailman/listinfo/nepomuk</a><br> \
</div></div></blockquote></div><br><br clear="all"><br>-- <br><span \
style="color:rgb(192,192,192)">Vishesh Handa</span><br><br>



_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic