[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-active
Subject:    Re: RFC: remove that star rating on top of bookmarks
From:       Sebastian =?iso-8859-1?q?K=FCgler?= <sebas () kde ! org>
Date:       2011-11-02 9:54:46
Message-ID: 201111021054.47161.sebas () kde ! org
[Download RAW message or body]

On Wednesday, November 02, 2011 10:27:46 Marco Martin wrote:
> now bookmarks look the same as the other items.
> 
> the preview seems broken. sebas that depends from your patch going into 
> kdelibs to work again, right?

Yes. I had removed the bookmarks preview last minutes before PA1, since it ran 
in-process, and would sometimes crash the shell -- not nice for generating a 
preview.

Since then I've done work to reimplement this in the Correct (tm) way, by 
using a KIO PreviewJob and thumbnail generator. This required a patch to 
kdelibs which makes PreviewJob accept URLs, not only local files, and a patch 
to kde-runtime adding the webkit-based previewer code as thumbnailer. The 
kdelibs patch will go in shortly (not sure about 4.7 or 4.8 though, since 
kdelibs is frozen -- we might have to ship this as patch), my kde-runtime 
patch needs cleanup and then is basically ready.

With those, we'll get the web previews back.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
_______________________________________________
Active mailing list
Active@kde.org
https://mail.kde.org/mailman/listinfo/active
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic