[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde
Subject:    Panel Icon Style Configuration(was : Re: Bug in KDE-1.1.2)
From:       Duncan Haldane <f.d.m.haldane () mciworld ! com>
Date:       1999-09-28 13:56:53
[Download RAW message or body]

This message is in MIME format


Panel Icon Style Configuration(was : Re: Bug in KDE-1.1.2)-----

Hi
I see that the weird duplicated panel icon size configuration
(in both kcmpanel and kcmdisplay control center modules)
in KDE-1.1.2 is found to be buggy.

This feature was added in June at the request of the Artist team
for configuring the new large Icons.

It almost got removed just before release of 1.1.2 because of the
apparent inconsistency for configuring in two places, and because the
code added to the display->style control center module didnt handle
"tiny" panel icon style.  But the Artist Team really wanted to keep
this feature....



Well, it was not known then that it was buggy....
With hindsight, it *should* have been removed.


Well, here is the patch that removes any configuration of
panel icon style (=icon size) by the Display->Style dialog.
Only the panel configuration dialog will configure this after
the patch to kdebase-1.1.2/kcontrol/display/general.cpp is
applied.


(This patch will be applied in future updates of the kdebase-1.1.2-*rh5x.*.rpm
and kdebase-1.1.2-*FHS2.*.rpm packages for RedHat)



duncan@kde.org




--- general.cpp Thu Sep  2 17:01:34 1999
+++ general.cpp-no_kpanel_config        Thu Sep  2 16:47:42 1999
@@ -202,15 +202,18 @@
 
 //------------------------------------------------------------------
 
-const char * KIconStyle::appName [] = {"kpanel", "kfm", "KDE"};
-const int KIconStyle::nApp = 3;
+const char * KIconStyle::appName [] = { //"kpanel", //suppressed
+                                        "kfm", "KDE"};
+const int KIconStyle::nApp = 2; //changed from nApp=3 to suppress kpanel
+                                //icon configuration in kcmdisplay; 
+                                //19990902 duncan@kde.org
 
 KIconStyle::KIconStyle( QWidget *parent, QBoxLayout * topLayout )
 {
-    const char *appTitle [] = { i18n("Panel"),
+  const char *appTitle [] = { //i18n("Panel"), //supressed
                                 i18n("File manager and desktop icons"),
                                 i18n("Other") };
-
+                                
     m_dictCBNormal.setAutoDelete(true);
     m_dictCBLarge.setAutoDelete(true);
     m_dictSettings.setAutoDelete(true);






["general.cpp.patch" (application/octet-stream)]
-- 
Send posts to:  kde@lists.netcentral.net
 Send all commands to:  kde-request@lists.netcentral.net
  Put your command in the SUBJECT of the message:
   "subscribe", "unsubscribe", "set digest on", or "set digest off"
PLEASE READ THE ARCHIVED MESSAGES AT http://lists.kde.org/ BEFORE POSTING
**********************************************************************
This list is from your pals at NetCentral <http://www.netcentral.net/>


[prev in list] [next in list] [prev in thread] [next in thread]