[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kbuild-devel
Subject:    [kbuild-devel] Re: [PATCH 2/2] Fix signed char problem in scripts/kconfig
From:       Roman Zippel <zippel () linux-m68k ! org>
Date:       2005-06-22 14:44:48
Message-ID: Pine.LNX.4.61.0506221642240.3728 () scrub ! home
[Download RAW message or body]

Hi,

On Wed, 22 Jun 2005, Pierre Ossman wrote:

> The signed characters in scripts are causing warnings with GCC 4 on
> systems with proper string functions (with char*, not signed char* as
> parameters). Some could be kept signed but most had to be reverted to
> normal chars.
> 
> Detailed changelog:
> 
> mconf.c:
> 	- buf/bufptr was used in vsprintf() so it couldn't be signed.
> confdata.c:
> 	- conf_expand_value() used strchr() and strncat() forcing
> 	  "normal" strings.
> conf.c:
> 	- line was used with several string functions so it couldn't be
> 	  signed.
> 	- strip() uses strlen() so same thing there.
> 
> Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>

Acked-by: Roman Zippel <zippel@linux-m68k.org>

Looks good, thanks.

bye, Roman


-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
_______________________________________________
kbuild-devel mailing list
kbuild-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kbuild-devel
[prev in list] [next in list] [prev in thread] [next in thread]