[prev in list] [next in list] [prev in thread] [next in thread] 

List:       k3b
Subject:    Re: Review Request 130034: Make Qt5WebKitWidgets optional
From:       Leslie Zhai <xiangzhai83 () gmail ! com>
Date:       2017-03-20 2:02:09
Message-ID: 20170320020209.13256.18420 () mimi ! kde ! org
[Download RAW message or body]

--===============9140642169854395100==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130034/#review102910
-----------------------------------------------------------


Ship it!




Ship It!

- Leslie Zhai


On 三月 20, 2017, 12:48 a.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130034/
> -----------------------------------------------------------
> 
> (Updated 三月 20, 2017, 12:48 a.m.)
> 
> 
> Review request for K3b and Leslie Zhai.
> 
> 
> Repository: k3b
> 
> 
> Description
> -------
> 
> It really is of very limited use here. The patch goes back to something
> Red Hat had been applying to k3b since at least 2012, but actually makes
> Qt5WebKitWidgets conditional instead of removing it completely.
> 
> 
> Diffs
> -----
> 
> CMakeLists.txt 808bd0b9a06d9cc5cc78555ef595f9a1165776e5 
> src/CMakeLists.txt 8ec0fbdf0a4ca1b9828eee6720e862e6dc565dad 
> src/k3bdiskinfoview.h 0b27e630d07ed70cb6c4433e6f6fe4af985d9c94 
> src/k3bdiskinfoview.cpp 1005ef8477da9ac863cf17e257f9ad228479daab 
> 
> Diff: https://git.reviewboard.kde.org/r/130034/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
> 


--===============9140642169854395100==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/130034/">https://git.reviewboard.kde.org/r/130034/</a>
  </td>
    </tr>
   </table>
   <br />



<p>

Ship it!

</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />









<p>- Leslie Zhai</p>


<br />
<p>On 三月 20th, 2017, 12:48 a.m. CST, Andreas Sturmlechner wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for K3b and Leslie Zhai.</div>
<div>By Andreas Sturmlechner.</div>


<p style="color: grey;"><i>Updated 三月 20, 2017, 12:48 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
k3b
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It really is of very limited use here. The patch goes back to something \
Red Hat had been applying to k3b since at least 2012, but actually makes \
Qt5WebKitWidgets conditional instead of removing it completely.</pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(808bd0b9a06d9cc5cc78555ef595f9a1165776e5)</span></li>

 <li>src/CMakeLists.txt <span style="color: \
grey">(8ec0fbdf0a4ca1b9828eee6720e862e6dc565dad)</span></li>

 <li>src/k3bdiskinfoview.h <span style="color: \
grey">(0b27e630d07ed70cb6c4433e6f6fe4af985d9c94)</span></li>

 <li>src/k3bdiskinfoview.cpp <span style="color: \
grey">(1005ef8477da9ac863cf17e257f9ad228479daab)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/130034/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============9140642169854395100==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic