'Re: Review Request 128860: Implementation of IMAGE_RAW'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       k3b
Subject:    Re: Review Request 128860: Implementation of IMAGE_RAW
From:       Leslie Zhai <xiangzhai83 () gmail ! com>
Date:       2016-12-02 5:25:10
Message-ID: 20161202052510.23280.55058 () mimi ! kde ! org
[Download RAW message or body]

--===============1420899293667178710==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128860/
-----------------------------------------------------------

(Updated 十二月 2, 2016, 1:25 p.m.)


Status
------

This change has been discarded.


Review request for K3b.


Bugs: 344392
    http://bugs.kde.org/show_bug.cgi?id=344392


Repository: k3b


Description
-------

Hi Thomas,

As suggested in [KDEBUG-344392](https://bugs.kde.org/show_bug.cgi?id=344392#c8) about \
introducing IMAGE_RAW type, I am trying to implement it, please review it and give \
some advice, thanks a lot!

Regards,
Leslie Zhai


Diffs
-----

  src/misc/k3bimagewritingdialog.cpp 0df6c76 

Diff: https://git.reviewboard.kde.org/r/128860/diff/


Testing
-------

dd if=/dev/zero bs=1M count=100 of=~/virt.img

cdemu create-blank --writer-id=WRITER-TOC --medium-type=cdr80 \
--param="writer.write_raw=1" --param="writer.write_subchannel=1" 0 ~/virt.toc

then burn virt.img with CDEmu virt disc PASS ;-) \
https://pbs.twimg.com/media/Cr39ZYEVYAUylmE.jpg


Thanks,

Leslie Zhai


--===============1420899293667178710==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128860/">https://git.reviewboard.kde.org/r/128860/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for K3b.</div>
<div>By Leslie Zhai.</div>


<p style="color: grey;"><i>Updated 十二月 2, 2016, 1:25 p.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=344392">344392</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
k3b
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hi Thomas,</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">As suggested in <a \
href="https://bugs.kde.org/show_bug.cgi?id=344392#c8" style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">KDEBUG-344392</a> about introducing IMAGE_RAW type, I am trying to implement \
it, please review it and give some advice, thanks a lot!</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Regards, Leslie Zhai</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">dd if=/dev/zero bs=1M count=100 of=~/virt.img</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">cdemu create-blank --writer-id=WRITER-TOC --medium-type=cdr80 \
--param="writer.write_raw=1" --param="writer.write_subchannel=1" 0 ~/virt.toc</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">then burn virt.img with CDEmu virt disc PASS ;-) \
https://pbs.twimg.com/media/Cr39ZYEVYAUylmE.jpg</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/misc/k3bimagewritingdialog.cpp <span style="color: \
grey">(0df6c76)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128860/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============1420899293667178710==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic