'Re: [k3b] Review Request 126646: Don't segfault when failing to load a plugin.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       k3b
Subject:    Re: [k3b] Review Request 126646: Don't segfault when failing to load a plugin.
From:       "Jeremy Whiting" <jpwhiting () kde ! org>
Date:       2016-01-12 3:02:09
Message-ID: 20160112030209.23702.17272 () mimi ! kde ! org
[Download RAW message or body]

--===============0560438037338754501==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126646/
-----------------------------------------------------------

(Updated Jan. 11, 2016, 8:02 p.m.)


Status
------

This change has been discarded.


Review request for K3b and Johannes Obermayr.


Repository: k3b


Description
-------

With today's build of kf5 branch k3b wouldn't start because the KPluginInfo for one \
of the plugins (I think the maddecoder most likely) fails to load and causes a \
segfault when trying to access the pluginName().


Diffs
-----

  src/k3bsystemproblemdialog.cpp 4e3022a 

Diff: https://git.reviewboard.kde.org/r/126646/diff/


Testing
-------

I added a qDebug() for valid plugins to see which name k3bmaddecoder is getting also, \
and fixed the name check in this patch. It's still failing to load though with debug \
output like this:

"K3b MAD Decoder" "k3bmaddecoder"
Loaded plugin "K3b MAD Decoder"
"k3bmaddecoder.desktop" has no desktop group, cannot construct a KPluginInfo object \
from it.

similar output for other plugins. It does seem to start and lets me add mp3 files to \
an audio cd project though with this change.


Thanks,

Jeremy Whiting


--===============0560438037338754501==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126646/">https://git.reviewboard.kde.org/r/126646/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for K3b and Johannes Obermayr.</div>
<div>By Jeremy Whiting.</div>


<p style="color: grey;"><i>Updated Jan. 11, 2016, 8:02 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
k3b
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">With today's build of kf5 branch k3b wouldn't start \
because the KPluginInfo for one of the plugins (I think the maddecoder most likely) \
fails to load and causes a segfault when trying to access the pluginName().</p></pre> \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I added a qDebug() for valid plugins to see which name \
k3bmaddecoder is getting also, and fixed the name check in this patch. It's still \
failing to load though with debug output like this:</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"K3b \
MAD Decoder" "k3bmaddecoder" Loaded plugin "K3b MAD Decoder"
"k3bmaddecoder.desktop" has no desktop group, cannot construct a KPluginInfo object \
from it.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">similar output for other plugins. It does seem to \
start and lets me add mp3 files to an audio cd project though with this \
change.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/k3bsystemproblemdialog.cpp <span style="color: grey">(4e3022a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126646/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============0560438037338754501==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic