[prev in list] [next in list] [prev in thread] [next in thread] 

List:       k3b
Subject:    [k3b] [Bug 341077] New: FLAC plugin's function seekToFrame may work incorrect
From:       Vitaliy <vitfunk () yandex ! ru>
Date:       2014-11-18 11:33:11
Message-ID: bug-341077-188845 () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=341077

            Bug ID: 341077
           Summary: FLAC plugin's function seekToFrame may work incorrect
           Product: k3b
           Version: unspecified
          Platform: unspecified
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Plugins
          Assignee: k3b@kde.org
          Reporter: vitfunk@yandex.ru
                CC: michalm@jabster.pl, trueg@kde.org

Multiply in the function seekToFrame may cause loss of data:
bool K3bFLACDecoder::Private::seekToFrame(int frame) {
    FLAC__uint64 sample = frame * rate / 75;
    return seek_absolute(sample);
}

Correct function:
bool K3bFLACDecoder::Private::seekToFrame(int frame) {
    FLAC__uint64 sample = static_cast<FLAC__uint64>(frame) * rate / 75;
    return seek_absolute(sample);
}

Reproducible: Sometimes

Steps to Reproduce:
1. Take the CD-Rip FLAC with CUE-sheet
2. Leave one random track from cd, remove other
3. Burn CD or make an image
4. Content of the track will different from the selected

-- 
You are receiving this mail because:
You are the assignee for the bug.
[prev in list] [next in list] [prev in thread] [next in thread]