[prev in list] [next in list] [prev in thread] [next in thread]
List: k3b
Subject: [k3b] Re: Review Request: Prefer growisofs to wodim for DVD/BluRay
From: "Kevin Kofler" <kevin.kofler () chello ! at>
Date: 2011-06-15 20:46:22
Message-ID: 20110615204622.11785.1612 () vidsolbach ! de
[Download RAW message or body]
> On June 15, 2011, 8:44 p.m., Commit Hook wrote:
> > This review has been submitted with commit \
> > 4b2b42a44b7aaee84bad511e91813382f160c35a by Kevin Kofler to branch master.
Do we want this in 2.0 too?
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101208/#review3913
-----------------------------------------------------------
On April 23, 2011, 1:49 p.m., Kevin Kofler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101208/
> -----------------------------------------------------------
>
> (Updated April 23, 2011, 1:49 p.m.)
>
>
> Review request for K3b.
>
>
> Summary
> -------
>
> K3b 2 defaults to cdrecord for all burning tasks, including DVDs and BluRay
> discs. Unfortunately, it also does this when cdrecord is actually wodim. This
> is a bad idea, because wodim's DVD burning code is not the "ProDVD" code in
> Jörg Schilling's current cdrecord releases, but a much older, buggier and
> basically unmaintained DVD patch. We cannot ship the ProDVD code in wodim
> because of licensing conflicts: That code was never released under the GPL, it
> was relicensed directly from its original proprietary license to the CDDL. But
> wodim is GPLed, and cannot be relicensed to the CDDL, in fact this was the
> whole reason for the fork: Jörg Schilling's cdrecord distributes mixed CDDL and
> GPL code linked together. So the DVD code in wodim is based on an ancient
> experimental community-contributed DVD support patch for cdrecord (from the
> times where ProDVD was entirely proprietary). So it's a bad idea to use wodim
> for DVDs. As for BluRay discs, those aren't currently supported by wodim at
> all; K3b should detect this, but still, it's better to explicitly default to
> growisofs there too, in case wodim grows some experimental BluRay support.
>
> One concrete known issue with wodim's DVD burning code is that it fails to burn
> dual-layer DVD+Rs: https://bugzilla.redhat.com/show_bug.cgi?id=610976 . But
> chances are there are many more DVD burning bugs in wodim, which are unlikely
> to get fixed promptly.
>
> Growisofs, on the other hand, is designed specifically for DVDs and BluRay
> disks, doesn't have licensing issues and has been used successfully for DVDs
> for years (in fact, K3b 1 always used growisofs for DVDs).
>
> This patch makes K3b default to growisofs for all DVD or BluRay burning tasks
> if cdrecord is actually wodim.
>
>
> Diffs
> -----
>
> libk3b/jobs/k3bdvdcopyjob.cpp b1a1cf6
> libk3b/jobs/k3bmetawriter.cpp 3aa981e
> libk3b/projects/datacd/k3bdatajob.cpp 1258d54
>
> Diff: http://git.reviewboard.kde.org/r/101208/diff
>
>
> Testing
> -------
>
> Awaiting feedback from Fedora users:
> https://admin.fedoraproject.org/updates/k3b-2.0.2-4.fc15
> https://admin.fedoraproject.org/updates/k3b-2.0.2-4.fc14
> https://admin.fedoraproject.org/updates/k3b-2.0.2-4.fc13
> https://bugzilla.redhat.com/show_bug.cgi?id=610976#c26
>
> I will update the status when we have some testing feedback.
>
>
> Thanks,
>
> Kevin
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101208/">http://git.reviewboard.kde.org/r/101208/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 15th, 2011, 8:44 p.m., <b>Commit Hook</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review \
has been submitted with commit 4b2b42a44b7aaee84bad511e91813382f160c35a by Kevin \
Kofler to branch master.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do we want this in 2.0 \
too?</pre> <br />
<p>- Kevin</p>
<br />
<p>On April 23rd, 2011, 1:49 p.m., Kevin Kofler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for K3b.</div>
<div>By Kevin Kofler.</div>
<p style="color: grey;"><i>Updated April 23, 2011, 1:49 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">K3b 2 defaults to cdrecord for all burning tasks, including DVDs and \
BluRay discs. Unfortunately, it also does this when cdrecord is actually wodim. This
is a bad idea, because wodim's DVD burning code is not the "ProDVD" \
code in Jörg Schilling's current cdrecord releases, but a much older, buggier \
and basically unmaintained DVD patch. We cannot ship the ProDVD code in wodim
because of licensing conflicts: That code was never released under the GPL, it
was relicensed directly from its original proprietary license to the CDDL. But
wodim is GPLed, and cannot be relicensed to the CDDL, in fact this was the
whole reason for the fork: Jörg Schilling's cdrecord distributes mixed CDDL and
GPL code linked together. So the DVD code in wodim is based on an ancient
experimental community-contributed DVD support patch for cdrecord (from the
times where ProDVD was entirely proprietary). So it's a bad idea to use wodim
for DVDs. As for BluRay discs, those aren't currently supported by wodim at
all; K3b should detect this, but still, it's better to explicitly default to
growisofs there too, in case wodim grows some experimental BluRay support.
One concrete known issue with wodim's DVD burning code is that it fails to burn
dual-layer DVD+Rs: https://bugzilla.redhat.com/show_bug.cgi?id=610976 . But
chances are there are many more DVD burning bugs in wodim, which are unlikely
to get fixed promptly.
Growisofs, on the other hand, is designed specifically for DVDs and BluRay
disks, doesn't have licensing issues and has been used successfully for DVDs
for years (in fact, K3b 1 always used growisofs for DVDs).
This patch makes K3b default to growisofs for all DVD or BluRay burning tasks
if cdrecord is actually wodim.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Awaiting feedback from Fedora users: \
https://admin.fedoraproject.org/updates/k3b-2.0.2-4.fc15 \
https://admin.fedoraproject.org/updates/k3b-2.0.2-4.fc14 \
https://admin.fedoraproject.org/updates/k3b-2.0.2-4.fc13 \
https://bugzilla.redhat.com/show_bug.cgi?id=610976#c26
I will update the status when we have some testing feedback.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libk3b/jobs/k3bdvdcopyjob.cpp <span style="color: grey">(b1a1cf6)</span></li>
<li>libk3b/jobs/k3bmetawriter.cpp <span style="color: grey">(3aa981e)</span></li>
<li>libk3b/projects/datacd/k3bdatajob.cpp <span style="color: \
grey">(1258d54)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101208/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic