[prev in list] [next in list] [prev in thread] [next in thread] 

List:       john-dev
Subject:    Re: [john-dev] [PATCH] OpenBSD disk encryption
From:       Thiébaud Weksteen <thiebaud () weksteen ! fr>
Date:       2014-11-13 10:53:04
Message-ID: 54648D90.8070707 () weksteen ! fr
[Download RAW message or body]

Hi all,

Thanks for your comments! As Dhiru has already merged the changes, I'll 
let it like that for now.

I've noticed that the Python script to extract the hashes from the disk 
image have been left out. (I think this was unintentional). I've made a 
pull request for it.

Cheers,
Thiébaud

On 13/11/14 21:16, Dhiru Kholia wrote:
> On Wed, 12 Nov 2014, magnum wrote:
>
>> On 2014-11-12 08:39, Thiébaud Weksteen wrote:
>>> I wrote a patch for bleeding-jumbo to handle OpenBSD disk encryption [1].
>>> I've also added a python script to extract the necessary values from a
>>> disk image.
>>>
>>> Before I submit a pull request to GitHub, I'd like your comments on it.
>> Thanks! I'll accept it as-is but there seem to be room for improvement: For
>> example, we have shared functions for PBKDF2-SHA1 using SSE2 and with some
>> other optimizations, it may be 3-8 times faster (see
>> pbkdf2-hmac-sha1_fmt_plug.c for example use). Also, just from a very quick
>> look it appears to me you could use a normal binary instead of treating it as
>> a "non-hash" but I may be wrong. And that will probably not matter unless you
>> try to crack lots of hashes at once, which is probably not the normal use
>> case.
> Hi!
>
> Thiébaud, thanks for the patch.
>
> magnum, I have removed the "cracked" approach and committed the code
> now.
>
> Dhiru

[prev in list] [next in list] [prev in thread] [next in thread]