[prev in list] [next in list] [prev in thread] [next in thread] 

List:       john-dev
Subject:    Re: [john-dev] Re: DEBUG support JTR
From:       Frank Dittrich <frank_dittrich () hotmail ! com>
Date:       2014-01-08 16:59:01
Message-ID: BLU0-SMTP286735FECFE8DCE0F87318FFDB10 () phx ! gbl
[Download RAW message or body]

On 01/08/2014 05:08 PM, Muhammad Junaid Muzammil wrote:
> I am in favour of adding debug support to build script. Do give me a signal
> to add if you people agree.

I think before adding even more build targets, we need to somewhat
cleanup and unify the Makefile.

E.g., define CLFAGS_COMKON that are common for debug and non-debug
builds, then separate flags for DEBUG and non-DEBUG builds.
This is further complicated by different flags needed for gcc and clang,
sometimes even depending on compiler version.

Also, many of the ../run/* targets use their own flags.
Sometimes there is a reason for that, sometimes probably not.

If you add a new debug target, it should not be advertised, i.e., add a
line to the default target, but turn it into a comment.
(Bash completion should still show the newly added target.)

Frank
[prev in list] [next in list] [prev in thread] [next in thread]