[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jmeter-dev
Subject:    svn commit: r948092 - in /jakarta/bcel/trunk/src/main/java/org/apache/bcel:
From:       sebb () apache ! org
Date:       2010-05-25 16:31:43
Message-ID: 20100525163143.A5EFC23889EA () eris ! apache ! org
[Download RAW message or body]

Author: sebb
Date: Tue May 25 16:31:42 2010
New Revision: 948092

URL: http://svn.apache.org/viewvc?rev=948092&view=rev
Log:
Make private immutable variables final

Modified:
    jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/Attribute.java
    jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/Unknown.java
    jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/InstructionFactory.java
    jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Type.java
    jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/SyntheticRepository.java
    jakarta/bcel/trunk/src/main/java/org/apache/bcel/verifier/VerifierFactory.java
    jakarta/bcel/trunk/src/main/java/org/apache/bcel/verifier/statics/DOUBLE_Upper.java
  jakarta/bcel/trunk/src/main/java/org/apache/bcel/verifier/statics/LONG_Upper.java
    jakarta/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/InstConstraintVisitor.java


Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/Attribute.java
URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/Attribute.java?rev=948092&r1=948091&r2=948092&view=diff
 ==============================================================================
--- jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/Attribute.java \
                (original)
+++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/Attribute.java Tue May \
25 16:31:42 2010 @@ -90,7 +90,7 @@ public abstract class Attribute implemen
 		file.writeInt(length);
 	}
 
-	private static Map readers = new HashMap();
+	private static final Map readers = new HashMap();
 
 	/**
 	 * Add an Attribute reader capable of parsing (user-defined) attributes

Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/Unknown.java
URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/Unknown.java?rev=948092&r1=948091&r2=948092&view=diff
 ==============================================================================
--- jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/Unknown.java \
                (original)
+++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/classfile/Unknown.java Tue May \
25 16:31:42 2010 @@ -45,7 +45,7 @@ public final class Unknown extends Attri
 
     private byte[] bytes;
     private String name;
-    private static Map unknown_attributes = new HashMap();
+    private static final Map unknown_attributes = new HashMap();
 
 
     /** @return array of unknown attributes, but just one for each kind.

Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/InstructionFactory.java
                
URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/InstructionFactory.java?rev=948092&r1=948091&r2=948092&view=diff
 ==============================================================================
--- jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/InstructionFactory.java \
                (original)
+++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/InstructionFactory.java \
Tue May 25 16:31:42 2010 @@ -154,7 +154,7 @@ public class InstructionFactory implemen
         return createInvoke(m.class_name, m.name, m.result_type, m.arg_types, kind);
     }
 
-    private static MethodObject[] append_mos = {
+    private static final MethodObject[] append_mos = {
             new MethodObject("java.lang.StringBuffer", "append", Type.STRINGBUFFER, \
new Type[] {  Type.STRING
             }, Constants.ACC_PUBLIC),

Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Type.java
URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Type.java?rev=948092&r1=948091&r2=948092&view=diff
 ==============================================================================
--- jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Type.java (original)
+++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/Type.java Tue May 25 \
16:31:42 2010 @@ -144,7 +144,7 @@ public abstract class Type implements ja
         return buf.toString();
     }
 
-    private static ThreadLocal consumed_chars = new ThreadLocal() {
+    private static final ThreadLocal consumed_chars = new ThreadLocal() {
 
         protected Object initialValue() {
             return new Integer(0);

Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/SyntheticRepository.java
                
URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/SyntheticRepository.java?rev=948092&r1=948091&r2=948092&view=diff
 ==============================================================================
--- jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/SyntheticRepository.java \
                (original)
+++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/util/SyntheticRepository.java \
Tue May 25 16:31:42 2010 @@ -49,7 +49,7 @@ import org.apache.bcel.classfile.JavaCla
 public class SyntheticRepository implements Repository {
 
     //private static final String DEFAULT_PATH = ClassPath.getClassPath();
-    private static Map _instances = new HashMap(); // CLASSPATH X REPOSITORY
+    private static final Map _instances = new HashMap(); // CLASSPATH X REPOSITORY
     private ClassPath _path = null;
     private Map _loadedClasses = new HashMap(); // CLASSNAME X JAVACLASS
 

Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/verifier/VerifierFactory.java
                
URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/verifier/VerifierFactory.java?rev=948092&r1=948091&r2=948092&view=diff
 ==============================================================================
--- jakarta/bcel/trunk/src/main/java/org/apache/bcel/verifier/VerifierFactory.java \
                (original)
+++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/verifier/VerifierFactory.java \
Tue May 25 16:31:42 2010 @@ -38,11 +38,11 @@ public class VerifierFactory {
     /**
      * The HashMap that holds the data about the already-constructed Verifier \
                instances.
      */
-    private static Map hashMap = new HashMap();
+    private static final Map hashMap = new HashMap();
     /**
      * The VerifierFactoryObserver instances that observe the VerifierFactory.
      */
-    private static List observers = new Vector();
+    private static final List observers = new Vector();
 
 
     /**

Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/verifier/statics/DOUBLE_Upper.java
                
URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/verifier/statics/DOUBLE_Upper.java?rev=948092&r1=948091&r2=948092&view=diff
 ==============================================================================
--- jakarta/bcel/trunk/src/main/java/org/apache/bcel/verifier/statics/DOUBLE_Upper.java \
                (original)
+++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/verifier/statics/DOUBLE_Upper.java \
Tue May 25 16:31:42 2010 @@ -29,7 +29,7 @@ import org.apache.bcel.generic.Type;
 public final class DOUBLE_Upper extends Type{
 
 	/** The one and only instance of this class. */
-	private static DOUBLE_Upper singleInstance = new DOUBLE_Upper();
+	private static final DOUBLE_Upper singleInstance = new DOUBLE_Upper();
 
 	/** The constructor; this class must not be instantiated from the outside. */
 	private DOUBLE_Upper(){

Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/verifier/statics/LONG_Upper.java
                
URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/verifier/statics/LONG_Upper.java?rev=948092&r1=948091&r2=948092&view=diff
 ==============================================================================
--- jakarta/bcel/trunk/src/main/java/org/apache/bcel/verifier/statics/LONG_Upper.java \
                (original)
+++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/verifier/statics/LONG_Upper.java \
Tue May 25 16:31:42 2010 @@ -29,7 +29,7 @@ import org.apache.bcel.generic.Type;
 public final class LONG_Upper extends Type{
 
 	/** The one and only instance of this class. */
-	private static LONG_Upper singleInstance = new LONG_Upper();
+	private static final LONG_Upper singleInstance = new LONG_Upper();
 
 	/** The constructor; this class must not be instantiated from the outside. */
 	private LONG_Upper(){

Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/InstConstraintVisitor.java
                
URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/ver \
ifier/structurals/InstConstraintVisitor.java?rev=948092&r1=948091&r2=948092&view=diff \
                ==============================================================================
                
--- jakarta/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/InstConstraintVisitor.java \
                (original)
+++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/InstConstraintVisitor.java \
Tue May 25 16:31:42 2010 @@ -53,7 +53,7 @@ import org.apache.bcel.verifier.exc.Stru
  */
 public class InstConstraintVisitor extends EmptyVisitor implements \
org.apache.bcel.generic.Visitor{  
-	private static ObjectType GENERIC_ARRAY = new \
ObjectType("org.apache.bcel.verifier.structurals.GenericArray"); +	private static \
final ObjectType GENERIC_ARRAY = new \
ObjectType("org.apache.bcel.verifier.structurals.GenericArray");  
 	/**
 	 * The constructor. Constructs a new instance of this class.



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic