[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jfs-discussion
Subject:    Re: [Jfs-discussion] [PATCH] jfs: set i_ctime when setting ACL
From:       "Michael L. Semon" <mlsemon35 () gmail ! com>
Date:       2014-02-14 18:33:24
Message-ID: 52FE6174.7040803 () gmail ! com
[Download RAW message or body]

Looks good.  acl test suite results are good and unchanged from
the previous run (JFS on 3.14.0-rc1 with your previous ACL fix).
xfstests results now look the same as what I remember from testing
kernels 3.11-3.13.

Testing was done on i686 Pentium 4 with 1280 MB of RAM, using
yesterday's git pull of kernel 3.14.0-rc2.  Lockdep was employed
this time, yielding no new splats over those reported previously.
CONFIG_AIO=n due to kernel issues, so POSIX AIO is not represented.

Thanks!

Michael

On 02/13/2014 05:00 PM, Dave Kleikamp wrote:
> This fixes a regression in 3.14-rc1 where xfstests generic/307 fails.
> 
> jfs sets the ctime on the inode when writing an xattr. Previously,
> jfs went ahead and stored an acl that can be completely represented
> in the traditional permission bits, so the ctime was always set in
> the xattr code. The new code doesn't bother storing the acl in that
> case, thus the ctime isn't getting set.
> 
> Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
> Reported-by: Michael L. Semon <mlsemon35@gmail.com>
> ---
>  fs/jfs/acl.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/jfs/acl.c b/fs/jfs/acl.c
> index e973b85..5a8ea16 100644
> --- a/fs/jfs/acl.c
> +++ b/fs/jfs/acl.c
> @@ -86,6 +86,8 @@ static int __jfs_set_acl(tid_t tid, struct inode *inode, int type,
>  		rc = posix_acl_equiv_mode(acl, &inode->i_mode);
>  		if (rc < 0)
>  			return rc;
> +		inode->i_ctime = CURRENT_TIME;
> +		mark_inode_dirty(inode);
>  		if (rc == 0)
>  			acl = NULL;
>  		break;
> 


------------------------------------------------------------------------------
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience.  Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
_______________________________________________
Jfs-discussion mailing list
Jfs-discussion@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jfs-discussion
[prev in list] [next in list] [prev in thread] [next in thread]