[prev in list] [next in list] [prev in thread] [next in thread] 

List:       jedit-devel
Subject:    [ jEdit-devel ] [ jedit-Patches-1692315 ] SideKick shouldn't insert
From:       "SourceForge.net" <noreply () sourceforge ! net>
Date:       2007-06-30 17:07:32
Message-ID: E1I4gQ0-0004zP-QY () sc8-sf-web23 ! sourceforge ! net
[Download RAW message or body]

Patches item #1692315, was opened at 2007-04-01 05:36
Message generated for change (Comment added) made by ezust
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1692315&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
> Resolution: Accepted
Priority: 5
Private: No
Submitted By: Robert McKinnon (robmckinnon)
> Assigned to: Kazutoshi Satoda (k_satoda)
Summary: SideKick shouldn't insert backspace char in buffer

Initial Comment:
In SideKickCompletionPopup.java, line 311 shouldn't be executed if char is the \
backspace char, i.e. we shouldn't insert the backspace char into the text buffer.

Was:

private void keyTyped(char ch)
{
  if(complete == null || complete.size() == 0)
  {
    view.getTextArea().userInput(ch);
    dispose();
  }
  ...

Should be:

private void keyTyped(char ch)
{
  if(complete == null || complete.size() == 0)
  {
    if (ch == '\b')
    {
      view.getTextArea().backspace();
    }
    else
    {
      view.getTextArea().userInput(ch);
    }
    dispose();
  }
  ...

----------------------------------------------------------------------

> Comment By: Alan Ezust (ezust)
Date: 2007-06-30 10:07

Message:
Logged In: YES 
user_id=935841
Originator: NO

oops, sorry. Yes, you can commit.

----------------------------------------------------------------------

Comment By: Kazutoshi Satoda (k_satoda)
Date: 2007-06-30 01:29

Message:
Logged In: YES 
user_id=1483238
Originator: NO

Ping.

Can I commit my patch to jEdit/trunk before the release
of 4.3pre10 and close this item as Fixed?


----------------------------------------------------------------------

Comment By: Kazutoshi Satoda (k_satoda)
Date: 2007-05-28 16:35

Message:
Logged In: YES 
user_id=1483238
Originator: NO

My patch is not for SideKick. It's for core
(JEditTextArea and TextArea). Sorry for not clarifying
that.

Are you OK for that, Alan?


----------------------------------------------------------------------

Comment By: Alan Ezust (ezust)
Date: 2007-05-28 16:13

Message:
Logged In: YES 
user_id=935841
Originator: NO

Yes kazutoshi,  you can commit to sidekick.



----------------------------------------------------------------------

Comment By: Kazutoshi Satoda (k_satoda)
Date: 2007-05-06 00:23

Message:
Logged In: YES 
user_id=1483238
Originator: NO

What about handling '\b' in userInput() method? I think
userInput('\b') generally should behave as backspace().
Similarly, userInput('\u007F') should behave as
delete(). I made a patch for that (attached). It also
updates the javadoc.

But I can't reproduce the original problem.

What parser can reproduce the problem? It seems to be
required the parser overrides canHandleBackspace()
method of SideKickParser and returns true.

Additianlly, It may be different between Windows and
Linux whether '\b' is passed as KEY_TYPED event.
Unfortunately, I don't have a Linux box.

Anyway, I think the attached patch will fix the problem
without any breakage. Can I just commit?

File Added: textare_userInput.patch

----------------------------------------------------------------------

Comment By: Robert McKinnon (robmckinnon)
Date: 2007-04-29 03:14

Message:
Logged In: YES 
user_id=374389
Originator: YES

To reproduce:
 1) start typing a method with autocompletion on
 2) when completion popup appears, press backspace key
 3) the backspace char incorrectly gets inserted into the buffer, on Linux
it's rendered as a square (since it's a non-viewable char)

Correct behaviour should be:
 3) backspace action occurs, last char entered is deleted and cursor moves
back one place

----------------------------------------------------------------------

Comment By: Alan Ezust (ezust)
Date: 2007-04-01 16:32

Message:
Logged In: YES 
user_id=935841
Originator: NO

I'm testing this patch but I don't observe any difference in behavior.
What are the steps to reproduce the bug/observe the fix?


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1692315&group_id=588

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
-- 
-----------------------------------------------
jEdit Developers' List
jEdit-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jedit-devel


[prev in list] [next in list] [prev in thread] [next in thread]